Re: [PATCH nft 0/3] support ct/meta key lookups at runtime

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Thu, Oct 27, 2016 at 12:36:05AM +0200, Florian Westphal wrote:
> I have a patch series to add support of hash (skb hash) and sym hash
> (symmetric skb hash) to nft_meta.
> 
> This series would allow extending meta without adding new hash/symhash
> keywords in the scanner.
> 
> What do you think?

Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>

Only one suggestion, instead of:

 return error(loc, "Could not parse %s, known ct keys are: %s", str, buf);

Looking at current error reporting:

 # nft add rule x y ct
 <cmdline>:1:18-18: Error: syntax error, unexpected newline
 add rule x y ct
                ^
Probably something like looks better:

 "syntax error, unexpected %s, known keys are %s"

Thanks.