netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Anders K. Pedersen | Cohaesio" <akp@cohaesio.com>
Cc: "netfilter-devel@vger.kernel.org" <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH v4 nftables] rt: introduce routing expression
Date: Fri, 28 Oct 2016 10:43:05 +0200	[thread overview]
Message-ID: <20161028084305.GA29228@salvia> (raw)
In-Reply-To: <1477634191.1059.30.camel@cohaesio.com>

One comment though, it would be great if you can send me a follow up
patch to update 

On Fri, Oct 28, 2016 at 05:56:32AM +0000, Anders K. Pedersen | Cohaesio wrote:
> diff --git a/tests/files/expr-rt b/tests/files/expr-rt
> new file mode 100644
> index 0000000..4c15409
> --- /dev/null
> +++ b/tests/files/expr-rt
> @@ -0,0 +1,21 @@
> +#! nft -f
> +
> +add table ip filter
> +add chain ip filter output { type filter hook output priority 0 ; }
> +
> +add table ip6 filter
> +add chain ip6 filter output { type filter hook output priority 0 ; }
> +
> +add table inet filter
> +add chain inet filter output { type filter hook output priority 0 ; }
> +
> +# rt: classid (see /etc/iproute2/rt_realms)
> +add rule ip filter output rt classid cosmos counter
> +add rule ip6 filter output rt classid cosmos counter
> +add rule inet filter output rt classid cosmos counter
> +
> +# rt: nexthop
> +add rule ip filter output rt nexthop 192.168.0.1 counter
> +add rule ip6 filter output rt nexthop fd00::1 counter
> +add rule inet filter output ether type ip rt nexthop 192.168.0.1 counter
> +add rule inet filter output ether type ip6 rt nexthop fd00::1 counter

Please, move this test to tests/py/inet/rt.t

You will also need to generate the rt.t.payload* files, it should be
easy to generate them, just a bit timeconsuming janitoring task, but
definitely not hard.

We'll remove test/files/ soon, several files there are
broken/obsolete, and remaining working stuff we will merge into
tests/shell.

Thanks.

  parent reply	other threads:[~2016-10-28  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28  5:56 [PATCH v4 nftables] rt: introduce routing expression Anders K. Pedersen | Cohaesio
2016-10-28  8:33 ` Pablo Neira Ayuso
2016-10-28  8:43 ` Pablo Neira Ayuso [this message]
2016-10-28 11:31   ` Anders K. Pedersen | Cohaesio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028084305.GA29228@salvia \
    --to=pablo@netfilter.org \
    --cc=akp@cohaesio.com \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).