From: Florian Westphal <fw@strlen.de>
To: Jon Jensen <jon@endpoint.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Correct manpage description of -n / --numeric option
Date: Sat, 29 Oct 2016 04:47:40 +0200 [thread overview]
Message-ID: <20161029024740.GC30951@breakpoint.cc> (raw)
In-Reply-To: <1477707863-19649-1-git-send-email-jon@endpoint.com>
Jon Jensen <jon@endpoint.com> wrote:
> "When used twice" was used twice. :) Make it match the description in
> main.c instead.
> Numeric output: Addresses and other information
> that might need network traffic to resolve to symbolic names
> - are shown numerically (default behaviour). When used twice,
> + are shown numerically (default behaviour). When used once,
> internet services are translated. When used twice, internet
> services and UIDs/GIDs are also shown numerically. When used
> three times, protocol numbers are also shown numerically.
That paragraph doesn't match what nft is doing:
nft list table filter
ip saddr 127.0.0.1 tcp dport ssh skuid "root"
nft -n list table filter
ip saddr 127.0.0.1 tcp dport ssh skuid "root"
nft -nn list table filter
ip saddr 127.0.0.1 tcp dport 22 skuid "root" // doc says this would be 'skuid 0'
src/nft -nnn list table filter
ip saddr 127.0.0.1 tcp dport 22 skuid 0
So I suggest a rewrite of that section, e.g.
Numeric output: Addresses and other information
that might need network traffic to resolve to symbolic names
are shown numerically (default behaviour). When used twice, internet
services (port numbers) are shown numerically. When used
three times, protocol numbers and UIDs/GIDs are also shown numerically.
(I don't like the repeated use of 'shown numerically', but I don't have
a better idea at the moment, and also don't care that much about this ..)
next prev parent reply other threads:[~2016-10-29 2:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 2:24 [PATCH] Correct manpage description of -n / --numeric option Jon Jensen
2016-10-29 2:47 ` Florian Westphal [this message]
2016-10-29 4:16 ` Jon Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161029024740.GC30951@breakpoint.cc \
--to=fw@strlen.de \
--cc=jon@endpoint.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).