From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: nf_tables: remove useless U8_MAX validation
Date: Mon, 31 Oct 2016 15:19:04 +0100 [thread overview]
Message-ID: <20161031141904.GA21641@salvia> (raw)
In-Reply-To: <1477749387-13304-1-git-send-email-zlpnobody@163.com>
On Sat, Oct 29, 2016 at 09:56:27PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> After call nft_data_init, size is already validated and desc.len will
> not exceed the sizeof(struct nft_data), i.e. 16 bytes. So it will never
> exceed U8_MAX.
>
> Furthermore, in nft_immediate_init, we forget to call nft_data_uninit
> when desc.len exceeds U8_MAX, although this will not happen, but it's
> a logical mistake.
>
> Now remove these redundant validation introduced by commit 36b701fae12a
> ("netfilter: nf_tables: validate maximum value of u32 netlink attributes")
Applied, thanks.
prev parent reply other threads:[~2016-10-31 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 13:56 [PATCH nf-next] netfilter: nf_tables: remove useless U8_MAX validation Liping Zhang
2016-10-31 14:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031141904.GA21641@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox