Re: [PATCH next] nft_meta: add skb hash get support

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]

Hi Florian,

[auto build test WARNING on next-20161028]

url:    https://github.com/0day-ci/linux/commits/Florian-Westphal/nft_meta-add-skb-hash-get-support/20161031-204758
config: i386-randconfig-x078-201644 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   net/netfilter/nft_meta.c: In function 'nft_meta_get_eval':
>> net/netfilter/nft_meta.c:197:36: warning: passing argument 1 of '__skb_get_hash_symmetric' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
      *dest = __skb_get_hash_symmetric(skb);
                                       ^~~
   In file included from include/linux/netlink.h:6:0,
                    from net/netfilter/nft_meta.c:14:
   include/linux/skbuff.h:1090:5: note: expected 'struct sk_buff *' but argument is of type 'const struct sk_buff *'
    u32 __skb_get_hash_symmetric(struct sk_buff *skb);
        ^~~~~~~~~~~~~~~~~~~~~~~~

vim +197 net/netfilter/nft_meta.c

   181		case NFT_META_CGROUP:
   182			sk = skb_to_full_sk(skb);
   183			if (!sk || !sk_fullsock(sk))
   184				goto err;
   185			*dest = sock_cgroup_classid(&sk->sk_cgrp_data);
   186			break;
   187	#endif
   188		case NFT_META_PRANDOM: {
   189			struct rnd_state *state = this_cpu_ptr(&nft_prandom_state);
   190			*dest = prandom_u32_state(state);
   191			break;
   192		}
   193		case NFT_META_HASH:
   194			*dest = skb_get_hash(pkt->skb);
   195			break;
   196		case NFT_META_SYMHASH:
 > 197			*dest = __skb_get_hash_symmetric(skb);
   198			break;
   199		default:
   200			WARN_ON(1);
   201			goto err;
   202		}
   203		return;
   204	
   205	err:

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 25103 bytes --]