From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH next] nft_meta: add skb hash get support
Date: Thu, 3 Nov 2016 17:47:50 +0100 [thread overview]
Message-ID: <20161103164750.GA8096@salvia> (raw)
In-Reply-To: <1477917869-26872-1-git-send-email-fw@strlen.de>
On Mon, Oct 31, 2016 at 01:44:29PM +0100, Florian Westphal wrote:
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> NB1: Alternative is to place this in nft_hash, but that uses
> an sreg so i think meta is fine.
Right. We may still reuse all these attributes though if we use the
hash expression:
* @NFTA_HASH_DREG: destination register (NLA_U32)
* @NFTA_HASH_MODULUS: modulus value (NLA_U32)
* @NFTA_HASH_OFFSET: add this offset value to hash result (NLA_U32)
This would need a new NFTA_HASH_TYPE, defaulting on jhash.
Otherwise we would need a scaling expression in case we want to use
this new meta field for load balancing just like af_packet fanout. Do
you prefer to follow up this path?
prev parent reply other threads:[~2016-11-03 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 12:44 [PATCH next] nft_meta: add skb hash get support Florian Westphal
2016-10-31 13:24 ` kbuild test robot
2016-10-31 14:24 ` Pablo Neira Ayuso
2016-11-03 16:47 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103164750.GA8096@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox