netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr
@ 2016-11-04  0:14 Cong Wang
  2016-11-04 10:58 ` Simon Horman
  0 siblings, 1 reply; 3+ messages in thread
From: Cong Wang @ 2016-11-04  0:14 UTC (permalink / raw)
  To: netdev; +Cc: netfilter-devel, andreyknvl, Cong Wang, Pablo Neira Ayuso

family.maxattr is the max index for policy[], the size of
ops[] is determined with ARRAY_SIZE().

Reported-by: Andrey Konovalov <andreyknvl@google.com>
Tested-by: Andrey Konovalov <andreyknvl@google.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
---
 net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index c3c809b..a6e44ef 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -2845,7 +2845,7 @@ static struct genl_family ip_vs_genl_family = {
 	.hdrsize	= 0,
 	.name		= IPVS_GENL_NAME,
 	.version	= IPVS_GENL_VERSION,
-	.maxattr	= IPVS_CMD_MAX,
+	.maxattr	= IPVS_CMD_ATTR_MAX,
 	.netnsok        = true,         /* Make ipvsadm to work on netns */
 };
 
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr
  2016-11-04  0:14 [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr Cong Wang
@ 2016-11-04 10:58 ` Simon Horman
  2016-11-08 22:53   ` Pablo Neira Ayuso
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2016-11-04 10:58 UTC (permalink / raw)
  To: Cong Wang; +Cc: netdev, netfilter-devel, andreyknvl, Pablo Neira Ayuso

On Thu, Nov 03, 2016 at 05:14:03PM -0700, Cong Wang wrote:
> family.maxattr is the max index for policy[], the size of
> ops[] is determined with ARRAY_SIZE().
> 
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Tested-by: Andrey Konovalov <andreyknvl@google.com>
> Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>


Signed-off-by: Simon Horman <horms@verge.net.au>

Pablo, can you take this one into nf?

> ---
>  net/netfilter/ipvs/ip_vs_ctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
> index c3c809b..a6e44ef 100644
> --- a/net/netfilter/ipvs/ip_vs_ctl.c
> +++ b/net/netfilter/ipvs/ip_vs_ctl.c
> @@ -2845,7 +2845,7 @@ static struct genl_family ip_vs_genl_family = {
>  	.hdrsize	= 0,
>  	.name		= IPVS_GENL_NAME,
>  	.version	= IPVS_GENL_VERSION,
> -	.maxattr	= IPVS_CMD_MAX,
> +	.maxattr	= IPVS_CMD_ATTR_MAX,
>  	.netnsok        = true,         /* Make ipvsadm to work on netns */
>  };
>  
> -- 
> 2.1.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr
  2016-11-04 10:58 ` Simon Horman
@ 2016-11-08 22:53   ` Pablo Neira Ayuso
  0 siblings, 0 replies; 3+ messages in thread
From: Pablo Neira Ayuso @ 2016-11-08 22:53 UTC (permalink / raw)
  To: Simon Horman; +Cc: Cong Wang, netdev, netfilter-devel, andreyknvl

On Fri, Nov 04, 2016 at 11:58:44AM +0100, Simon Horman wrote:
> On Thu, Nov 03, 2016 at 05:14:03PM -0700, Cong Wang wrote:
> > family.maxattr is the max index for policy[], the size of
> > ops[] is determined with ARRAY_SIZE().
> > 
> > Reported-by: Andrey Konovalov <andreyknvl@google.com>
> > Tested-by: Andrey Konovalov <andreyknvl@google.com>
> > Cc: Pablo Neira Ayuso <pablo@netfilter.org>
> > Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> 
> 
> Signed-off-by: Simon Horman <horms@verge.net.au>
> 
> Pablo, can you take this one into nf?

Applied, thanks!

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-08 22:54 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-04  0:14 [Patch net] ipvs: use IPVS_CMD_ATTR_MAX for family.maxattr Cong Wang
2016-11-04 10:58 ` Simon Horman
2016-11-08 22:53   ` Pablo Neira Ayuso

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).