From: Florian Westphal <fw@strlen.de>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: pablo@netfilter.org, kaber@trash.net, kadlec@blackhole.kfki.hu,
davem@davemloft.net, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, christophe.jaillet@wanadoo.fr
Subject: Re: question about xt_find_table_lock
Date: Fri, 11 Nov 2016 12:23:07 +0100 [thread overview]
Message-ID: <20161111112307.GA7274@breakpoint.cc> (raw)
In-Reply-To: <alpine.DEB.2.20.1611111141380.2074@hadrien>
Julia Lawall <julia.lawall@lip6.fr> wrote:
> The function xt_find_table_lock defined in net/netfilter/x_tables.c is
> preceeded by a comment that says that it returns ERR_PTR() on error. But
> looking at the definition, I only see occurrences of return NULL and
> returns of pointers that have previously been dereferenced. Is it the
> code or the documentation that is incorrect? The call sites seem to be
> using IS_ERR_OR_NULL. Is there a plan to return ERR_PTR values in the
> future?
It used to return ERR_PTR, see:
commit 7926dbfa4bc14e27f4e18a6184a031a1c1e077dc
netfilter: don't use mutex_lock_interruptible()
So the comment isn't correct anymore and callers could test vs NULL.
next prev parent reply other threads:[~2016-11-11 11:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 10:49 question about xt_find_table_lock Julia Lawall
2016-11-11 11:23 ` Florian Westphal [this message]
2016-11-11 11:58 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161111112307.GA7274@breakpoint.cc \
--to=fw@strlen.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=julia.lawall@lip6.fr \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).