From: Pablo Neira Ayuso <pablo@netfilter.org>
To: David Ahern <dsa@cumulusnetworks.com>
Cc: kaber@trash.net, kadlec@blackhole.kfki.hu,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] netfilter: Update nf_send_reset6 to consider L3 domain
Date: Thu, 24 Nov 2016 12:46:29 +0100 [thread overview]
Message-ID: <20161124114629.GB11284@salvia> (raw)
In-Reply-To: <1478715905-19005-1-git-send-email-dsa@cumulusnetworks.com>
On Wed, Nov 09, 2016 at 10:25:05AM -0800, David Ahern wrote:
> nf_send_reset6 is not considering the L3 domain and lookups are sent
> to the wrong table. For example consider the following output rule:
>
> ip6tables -A OUTPUT -p tcp --dport 12345 -j REJECT --reject-with tcp-reset
>
> using perf to analyze lookups via the fib6_table_lookup tracepoint shows:
>
> swapper 0 [001] 248.787816: fib6:fib6_table_lookup: table 255 oif 0 iif 1 src 2100:1::3 dst 2100:1:
> ffffffff81439cdc perf_trace_fib6_table_lookup ([kernel.kallsyms])
> ffffffff814c1ce3 trace_fib6_table_lookup ([kernel.kallsyms])
> ffffffff814c3e89 ip6_pol_route ([kernel.kallsyms])
> ffffffff814c40d5 ip6_pol_route_output ([kernel.kallsyms])
> ffffffff814e7b6f fib6_rule_action ([kernel.kallsyms])
> ffffffff81437f60 fib_rules_lookup ([kernel.kallsyms])
> ffffffff814e7c79 fib6_rule_lookup ([kernel.kallsyms])
> ffffffff814c2541 ip6_route_output_flags ([kernel.kallsyms])
> 528 nf_send_reset6 ([nf_reject_ipv6])
>
> The lookup is directed to table 255 rather than the table associated with
> the device via the L3 domain. Update nf_send_reset6 to pull the L3 domain
> from the dst currently attached to the skb.
Also applied, thanks.
prev parent reply other threads:[~2016-11-24 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 18:25 [PATCH] netfilter: Update nf_send_reset6 to consider L3 domain David Ahern
2016-11-24 11:46 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124114629.GB11284@salvia \
--to=pablo@netfilter.org \
--cc=dsa@cumulusnetworks.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).