From: Florian Westphal <fw@strlen.de>
To: Liping Zhang <zlpnobody@163.com>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org,
fw@strlen.de, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next] netfilter: nft_fib_ipv4: initialize *dest to zero
Date: Thu, 24 Nov 2016 13:54:43 +0100 [thread overview]
Message-ID: <20161124125443.GC24598@breakpoint.cc> (raw)
In-Reply-To: <1479910341-40744-2-git-send-email-zlpnobody@163.com>
Liping Zhang <zlpnobody@163.com> wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> Otherwise, if fib lookup fail, *dest will be filled with garbage value,
> so reverse path filtering will not work properly:
> # nft add rule x prerouting fib saddr oif eq 0 drop
>
> Fixes: f6d0cbcf09c5 ("netfilter: nf_tables: add fib expression")
> Signed-off-by: Liping Zhang <zlpnobody@gmail.com>
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2016-11-24 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 14:12 [PATCH nf-next] netfilter: nft_fib: convert htonl to ntohl properly Liping Zhang
2016-11-23 14:12 ` [PATCH nf-next] netfilter: nft_fib_ipv4: initialize *dest to zero Liping Zhang
2016-11-24 12:54 ` Florian Westphal [this message]
2016-12-04 20:14 ` Pablo Neira Ayuso
2016-11-24 12:13 ` [PATCH nf-next] netfilter: nft_fib: convert htonl to ntohl properly Florian Westphal
2016-12-04 20:14 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124125443.GC24598@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).