From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Elise Lennion <elise.lennion@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v3 1/2] datatype: Replace getnameinfo() by internal lookup table
Date: Tue, 29 Nov 2016 20:19:11 +0100 [thread overview]
Message-ID: <20161129191911.GA2305@salvia> (raw)
In-Reply-To: <20161128202009.GA8734@lennorien.com>
On Mon, Nov 28, 2016 at 06:20:10PM -0200, Elise Lennion wrote:
[...]
> diff --git a/src/services.c b/src/services.c
> new file mode 100644
> index 0000000..8cb1cdf
> --- /dev/null
> +++ b/src/services.c
> @@ -0,0 +1,343 @@
> +#include <nftables.h>
> +#include <datatype.h>
> +
> +const struct symbol_table serv_tbl = {
> + .symbols = {
> + SYMBOL("exec", 2),
Please, use __constant_htons() so these ports become understandable.
Let's keep it simple, so we forget on binary search by now.
Very much looking forward to having this in the nft tree.
Thanks!
prev parent reply other threads:[~2016-11-29 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 20:20 [PATCH nft v3 1/2] datatype: Replace getnameinfo() by internal lookup table Elise Lennion
2016-11-29 19:19 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129191911.GA2305@salvia \
--to=pablo@netfilter.org \
--cc=elise.lennion@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox