From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Anatole Denis <anatole@rezel.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 1/3] evaluate: Add set to cache only when well-formed
Date: Tue, 29 Nov 2016 21:55:27 +0100 [thread overview]
Message-ID: <20161129205527.GA19613@salvia> (raw)
In-Reply-To: <b02aab6dfd61eff6e5fd9b2e517fd13f493e4887.1480350941.git.anatole@rezel.net>
On Mon, Nov 28, 2016 at 05:43:08PM +0100, Anatole Denis wrote:
> When creating a set (in set_evaluate), it is added to the table cache before
> being checked for correctness. When the set is ill-formed, the function returns
> without removing the (non-existent, since the function returned) set. Further
> references to this set will not result in an error (since the set is in the
> lookup table), but the malformed set will probably cause a segfault.
>
> The symptom (the segfault) was fixed by checking for NULL when evaluating a
> reference to the set (commit 5afa5a164ff1c066af1ec56d875b91562882bd50), this
> should fix the root cause.
Applied, thanks.
prev parent reply other threads:[~2016-11-29 20:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 16:43 [PATCH nft 1/3] evaluate: Add set to cache only when well-formed Anatole Denis
2016-11-28 16:43 ` [PATCH nft 2/3] tests: Add regression test for malformed sets Anatole Denis
2016-11-29 21:02 ` Pablo Neira Ayuso
2016-11-28 16:43 ` [PATCH nft 3/3] Revert "evaluate: check for NULL datatype in rhs in lookup expr" Anatole Denis
2016-11-29 21:02 ` Pablo Neira Ayuso
2016-11-29 20:55 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129205527.GA19613@salvia \
--to=pablo@netfilter.org \
--cc=anatole@rezel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).