From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Anatole Denis <anatole@rezel.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] evaluate: Update cache on flush ruleset
Date: Thu, 1 Dec 2016 12:42:02 +0100 [thread overview]
Message-ID: <20161201114202.GA3052@salvia> (raw)
In-Reply-To: <8cb247352dd4b9eaf587c1ff89f618061042edff.1480587885.git.anatole@rezel.net>
On Thu, Dec 01, 2016 at 11:50:17AM +0100, Anatole Denis wrote:
> After a flush, the cache should be empty, otherwise the cache and the expected
> state are desynced, causing unwarranted errors. See
> tests/shell/testcases/cache/0002_interval_0.
>
> `flush table` and `flush chain` don't empty sets or destroy chains, so the cache
> does not need an update in those cases, since only chain names and set contents
> are held in cache for commands other than "list"
Also applied, thanks.
next prev parent reply other threads:[~2016-12-01 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 10:50 [PATCH nft 1/2] rule: Introduce helper function cache_flush Anatole Denis
2016-12-01 10:50 ` [PATCH nft 2/2] evaluate: Update cache on flush ruleset Anatole Denis
2016-12-01 11:42 ` Pablo Neira Ayuso [this message]
2016-12-01 11:41 ` [PATCH nft 1/2] rule: Introduce helper function cache_flush Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161201114202.GA3052@salvia \
--to=pablo@netfilter.org \
--cc=anatole@rezel.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).