netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	daniel@iogearbox.net, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH nf-next] netfilter: xt_bpf: support ebpf
Date: Mon, 5 Dec 2016 23:34:15 +0100	[thread overview]
Message-ID: <20161205223415.GA14689@salvia> (raw)
In-Reply-To: <20161205213001.GA16819@breakpoint.cc>

On Mon, Dec 05, 2016 at 10:30:01PM +0100, Florian Westphal wrote:
> Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > On Mon, 2016-12-05 at 15:28 -0500, Willem de Bruijn wrote:
> > > From: Willem de Bruijn <willemb@google.com>
> > > 
> > > Add support for attaching an eBPF object by file descriptor.
> > > 
> > > The iptables binary can be called with a path to an elf object or a
> > > pinned bpf object. Also pass the mode and path to the kernel to be
> > > able to return it later for iptables dump and save.
> > > 
> > > Signed-off-by: Willem de Bruijn <willemb@google.com>
> > > ---
> > 
> > Assuming there is no simple way to get variable matchsize in iptables,
> > this looks good to me, thanks.
> 
> It should be possible by setting kernel .matchsize to ~0 which
> suppresses strict size enforcement.
> 
> Its currently only used by ebt_among, but this should work for any xtables
> module.

This is likely going to trigger a large rewrite of the core userspace
iptables codebase, and likely going to pull part of the mess we have
in ebtables into iptables. So I'd prefer not to follow this path.

  reply	other threads:[~2016-12-05 22:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-05 20:28 [PATCH nf-next] netfilter: xt_bpf: support ebpf Willem de Bruijn
2016-12-05 21:06 ` Eric Dumazet
2016-12-05 21:30   ` Florian Westphal
2016-12-05 22:34     ` Pablo Neira Ayuso [this message]
2016-12-05 22:40       ` Florian Westphal
2016-12-05 22:59         ` Eric Dumazet
2016-12-05 23:05           ` Pablo Neira Ayuso
2016-12-05 23:00       ` Pablo Neira Ayuso
2016-12-05 23:06         ` Willem de Bruijn
2016-12-05 23:22           ` Pablo Neira Ayuso
2016-12-05 23:29             ` Willem de Bruijn
2016-12-05 23:51               ` Willem de Bruijn
2016-12-06  0:20                 ` Florian Westphal
2016-12-06 22:44                   ` Willem de Bruijn
2016-12-05 22:55 ` Daniel Borkmann
2016-12-05 23:01   ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161205223415.GA14689@salvia \
    --to=pablo@netfilter.org \
    --cc=daniel@iogearbox.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fw@strlen.de \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).