From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [bug report] netfilter: nft_payload: layer 4 checksum adjustment for pseudoheader fields
Date: Tue, 6 Dec 2016 13:32:49 +0100 [thread overview]
Message-ID: <20161206123249.GA14969@salvia> (raw)
In-Reply-To: <20161206122453.GH8244@mwanda>
On Tue, Dec 06, 2016 at 03:24:53PM +0300, Dan Carpenter wrote:
> On Tue, Dec 06, 2016 at 01:16:08PM +0100, Pablo Neira Ayuso wrote:
> > On Tue, Dec 06, 2016 at 02:57:34PM +0300, Dan Carpenter wrote:
> > > Hello Pablo Neira Ayuso,
> > >
> > > The patch 556c291b3a1b: "netfilter: nft_payload: layer 4 checksum
> > > adjustment for pseudoheader fields" from Nov 24, 2016, leads to the
> > > following static checker warning:
> > >
> > > net/netfilter/nft_payload.c:301 nft_payload_set_eval()
> > > error: uninitialized symbol 'fsum'.
> >
> > This should restrict this case you're reporting here:
> >
> > http://git.kernel.org/cgit/linux/kernel/git/pablo/nf-next.git/commit/?id=a3c91a548b9b9f05f81e7bfe7fec3544a376269a
> >
> > Otherwise let me know, thanks.
>
> That works... Seems like it would have been easier to just move it
> under the if statement though...
Right. Will revisit this, thanks.
prev parent reply other threads:[~2016-12-06 12:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 11:57 [bug report] netfilter: nft_payload: layer 4 checksum adjustment for pseudoheader fields Dan Carpenter
2016-12-06 12:16 ` Pablo Neira Ayuso
2016-12-06 12:24 ` Dan Carpenter
2016-12-06 12:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161206123249.GA14969@salvia \
--to=pablo@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).