From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 37/50] netfilter: nf_tables: atomic dump and reset for stateful objects Date: Fri, 9 Dec 2016 11:24:32 +0100 Message-ID: <20161209102432.GA986@salvia> References: <1481147576-5690-1-git-send-email-pablo@netfilter.org> <1481147576-5690-38-git-send-email-pablo@netfilter.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="gKMricLos+KVdGMg" Cc: netfilter-devel@vger.kernel.org, David Miller , netdev , "linux-next@vger.kernel.org" To: Paul Gortmaker Return-path: Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org --gKMricLos+KVdGMg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Paul, On Thu, Dec 08, 2016 at 07:40:14PM -0500, Paul Gortmaker wrote: > On Wed, Dec 7, 2016 at 4:52 PM, Pablo Neira Ayuso wrote: > > This patch adds a new NFT_MSG_GETOBJ_RESET command perform an atomic > > dump-and-reset of the stateful object. This also comes with add support > > for atomic dump and reset for counter and quota objects. > > This triggered a new build failure in linux-next on parisc-32, which a > hands-off bisect > run lists as resulting from this: > > ERROR: "__cmpxchg_u64" [net/netfilter/nft_counter.ko] undefined! > make[2]: *** [__modpost] Error 1 > make[1]: *** [modules] Error 2 > make: *** [sub-make] Error 2 > 43da04a593d8b2626f1cf4b56efe9402f6b53652 is the first bad commit > commit 43da04a593d8b2626f1cf4b56efe9402f6b53652 > Author: Pablo Neira Ayuso > Date: Mon Nov 28 00:05:44 2016 +0100 > > netfilter: nf_tables: atomic dump and reset for stateful objects > > This patch adds a new NFT_MSG_GETOBJ_RESET command perform an atomic > dump-and-reset of the stateful object. This also comes with add support > for atomic dump and reset for counter and quota objects. > > Signed-off-by: Pablo Neira Ayuso > > :040000 040000 6cd4554f69247e5c837db52342f26888beda1623 > 5908aca93c89e7922336546c3753bfcf2aceefba M include > :040000 040000 f25d5831eb30972436bd198c5bb237a0cb0b4856 > 4ee5751c8de02bb5a8dcaadb2a2df7986d90f8e9 M net > bisect run success > > Guessing this is more an issue with parisc than it is with netfilter, but I > figured I'd mention it anyway. I'm planning to submit this patch to parisc, I'm attaching it to this email. --gKMricLos+KVdGMg Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-parisc-export-symbol-__cmpxchg_u64.patch" >>From c9d320ac0be2a32a7b2bfad398be549865088ecf Mon Sep 17 00:00:00 2001 From: Pablo Neira Ayuso Date: Thu, 8 Dec 2016 22:55:33 +0100 Subject: [PATCH] parisc: export symbol __cmpxchg_u64() kbuild test robot reports: >> ERROR: "__cmpxchg_u64" [net/netfilter/nft_counter.ko] undefined! Commit 43da04a593d8 ("netfilter: nf_tables: atomic dump and reset for stateful objects") introduces the first client of cmpxchg64() from modules. Patch 54b668009076 ("parisc: Add native high-resolution sched_clock() implementation") removed __cmpxchg_u64() dependency on CONFIG_64BIT. So, let's fix this problem by exporting this symbol unconditionally. Reported-by: kbuild test robot Signed-off-by: Pablo Neira Ayuso --- arch/parisc/kernel/parisc_ksyms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/parisc/kernel/parisc_ksyms.c b/arch/parisc/kernel/parisc_ksyms.c index 3cad8aadc69e..cfa704548cf3 100644 --- a/arch/parisc/kernel/parisc_ksyms.c +++ b/arch/parisc/kernel/parisc_ksyms.c @@ -40,8 +40,8 @@ EXPORT_SYMBOL(__atomic_hash); #endif #ifdef CONFIG_64BIT EXPORT_SYMBOL(__xchg64); -EXPORT_SYMBOL(__cmpxchg_u64); #endif +EXPORT_SYMBOL(__cmpxchg_u64); #include EXPORT_SYMBOL(lclear_user); -- 2.1.4 --gKMricLos+KVdGMg--