From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Elise Lennion <elise.lennion@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] datatype: Display pre-defined inet_service values in decimal base
Date: Sun, 11 Dec 2016 20:36:26 +0100 [thread overview]
Message-ID: <20161211193626.GA32234@salvia> (raw)
In-Reply-To: <20161210235936.GA4967@lennorien.com>
On Sat, Dec 10, 2016 at 09:59:36PM -0200, Elise Lennion wrote:
> because the convention is to represent ports in base 10.
>
> gcc-workaround is no longer needed and was removed.
Applied, thanks Elise.
It would be good if you can send a follow up patch to modified this
message that nft describe prints:
pre-defined symbolic constants:
to:
pre-defined symbolic constants (in hexadecimal):
^^^^^^^^^^^^^^^^
So the user knows how we express it.
Please, also review all existing symbol tables and add the base to
them, I guess a bit of googling should lead you to the right
convention dependending on the datatype, in case of doubt, make a
summary and ask for feedback on the mailing list.
Thanks.
prev parent reply other threads:[~2016-12-11 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 23:59 [PATCH nft] datatype: Display pre-defined inet_service values in decimal base Elise Lennion
2016-12-11 19:36 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161211193626.GA32234@salvia \
--to=pablo@netfilter.org \
--cc=elise.lennion@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).