netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [-stable 4.8.y] Revert NAT conversion to rhashtable
@ 2016-12-19 16:43 Pablo Neira Ayuso
  2017-01-04 17:30 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2016-12-19 16:43 UTC (permalink / raw)
  To: stable; +Cc: Greg Kroah-Hartman, netfilter-devel, fw, davem

Hi Greg,

Please revert the following two patches from 4.8.y:

870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat
bysrc hash to rhashtable")

7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat
hlist_head to nf_conn")

There are incremental fixes in 4.9 to resolve the problems in these
two, but they also require the new rhlist interface not available
there.

Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [-stable 4.8.y] Revert NAT conversion to rhashtable
  2016-12-19 16:43 [-stable 4.8.y] Revert NAT conversion to rhashtable Pablo Neira Ayuso
@ 2017-01-04 17:30 ` Greg Kroah-Hartman
  2017-01-05 10:52   ` Pablo Neira Ayuso
  0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-01-04 17:30 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: stable, netfilter-devel, fw, davem

On Mon, Dec 19, 2016 at 05:43:33PM +0100, Pablo Neira Ayuso wrote:
> Hi Greg,
> 
> Please revert the following two patches from 4.8.y:
> 
> 870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat
> bysrc hash to rhashtable")
> 
> 7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat
> hlist_head to nf_conn")
> 
> There are incremental fixes in 4.9 to resolve the problems in these
> two, but they also require the new rhlist interface not available
> there.

Now reverted, thanks!

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [-stable 4.8.y] Revert NAT conversion to rhashtable
  2017-01-04 17:30 ` Greg Kroah-Hartman
@ 2017-01-05 10:52   ` Pablo Neira Ayuso
  2017-01-05 11:45     ` Greg Kroah-Hartman
  0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2017-01-05 10:52 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: stable, netfilter-devel, fw, davem

On Wed, Jan 04, 2017 at 06:30:36PM +0100, Greg Kroah-Hartman wrote:
> On Mon, Dec 19, 2016 at 05:43:33PM +0100, Pablo Neira Ayuso wrote:
> > Hi Greg,
> > 
> > Please revert the following two patches from 4.8.y:
> > 
> > 870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat
> > bysrc hash to rhashtable")
> > 
> > 7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat
> > hlist_head to nf_conn")
> > 
> > There are incremental fixes in 4.9 to resolve the problems in these
> > two, but they also require the new rhlist interface not available
> > there.
> 
> Now reverted, thanks!

thanks a lot Greg.

I have more updates for you, will be sending them asap.

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [-stable 4.8.y] Revert NAT conversion to rhashtable
  2017-01-05 10:52   ` Pablo Neira Ayuso
@ 2017-01-05 11:45     ` Greg Kroah-Hartman
  0 siblings, 0 replies; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-01-05 11:45 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: stable, netfilter-devel, fw, davem

On Thu, Jan 05, 2017 at 11:52:07AM +0100, Pablo Neira Ayuso wrote:
> On Wed, Jan 04, 2017 at 06:30:36PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Dec 19, 2016 at 05:43:33PM +0100, Pablo Neira Ayuso wrote:
> > > Hi Greg,
> > > 
> > > Please revert the following two patches from 4.8.y:
> > > 
> > > 870190a9ec9075205c0fa795a09fa931694a3ff1 ("netfilter: nat: convert nat
> > > bysrc hash to rhashtable")
> > > 
> > > 7c9664351980aaa6a4b8837a314360b3a4ad382a ("netfilter: move nat
> > > hlist_head to nf_conn")
> > > 
> > > There are incremental fixes in 4.9 to resolve the problems in these
> > > two, but they also require the new rhlist interface not available
> > > there.
> > 
> > Now reverted, thanks!
> 
> thanks a lot Greg.
> 
> I have more updates for you, will be sending them asap.

If they are for 4.8, don't worry too much about that kernel, it will go
end-of-life in another release.  But patches for 4.4 and 4.9 are greatly
appreciated if you have them.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-05 11:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-19 16:43 [-stable 4.8.y] Revert NAT conversion to rhashtable Pablo Neira Ayuso
2017-01-04 17:30 ` Greg Kroah-Hartman
2017-01-05 10:52   ` Pablo Neira Ayuso
2017-01-05 11:45     ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).