* [PATCH] net/bridge: Fix dropping packets that moving through bridge interface
@ 2016-12-30 16:46 Artur Molchanov
2016-12-30 16:58 ` Florian Westphal
0 siblings, 1 reply; 4+ messages in thread
From: Artur Molchanov @ 2016-12-30 16:46 UTC (permalink / raw)
To: Pablo Neira Ayuso, netfilter-devel
From: Artur Molchanov <artur.molchanov@synesis.ru>
Fixes: c5136b15ea36 ("netfilter: bridge: add and use br_nf_hook_thresh")
Problem:
br_nf_pre_routing_finish() calls itself instead of
br_nf_pre_routing_finish_bridge().
Due to this bug reverse path filter drops packets that moving through
bridge interface.
User impact:
Local docker containers with bridge network can not communicate with
each other.
Signed-off-by: Artur Molchanov <artur.molchanov@synesis.ru>
---
net/bridge/br_netfilter_hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netfilter_hooks.c
b/net/bridge/br_netfilter_hooks.c
index 8ca6a92..95087e6 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -399,7 +399,7 @@ static int br_nf_pre_routing_finish(struct net *net,
struct sock *sk, struct sk_
br_nf_hook_thresh(NF_BR_PRE_ROUTING,
net, sk, skb, skb->dev,
NULL,
- br_nf_pre_routing_finish);
+ br_nf_pre_routing_finish_bridge);
return 0;
}
ether_addr_copy(eth_hdr(skb)->h_dest, dev->dev_addr);
--
2.8.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net/bridge: Fix dropping packets that moving through bridge interface
2016-12-30 16:46 [PATCH] net/bridge: Fix dropping packets that moving through bridge interface Artur Molchanov
@ 2016-12-30 16:58 ` Florian Westphal
2016-12-30 17:22 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Florian Westphal @ 2016-12-30 16:58 UTC (permalink / raw)
To: Artur Molchanov; +Cc: Pablo Neira Ayuso, netfilter-devel
Artur Molchanov <arturmolchanov@gmail.com> wrote:
> From: Artur Molchanov <artur.molchanov@synesis.ru>
>
> Fixes: c5136b15ea36 ("netfilter: bridge: add and use br_nf_hook_thresh")
>
> Problem:
> br_nf_pre_routing_finish() calls itself instead of
> br_nf_pre_routing_finish_bridge().
> Due to this bug reverse path filter drops packets that moving through
> bridge interface.
Indeed, thanks for fixing this!
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/bridge: Fix dropping packets that moving through bridge interface
2016-12-30 16:58 ` Florian Westphal
@ 2016-12-30 17:22 ` Pablo Neira Ayuso
2017-01-05 7:11 ` Artur Molchanov
0 siblings, 1 reply; 4+ messages in thread
From: Pablo Neira Ayuso @ 2016-12-30 17:22 UTC (permalink / raw)
To: Florian Westphal; +Cc: Artur Molchanov, netfilter-devel
On Fri, Dec 30, 2016 at 05:58:11PM +0100, Florian Westphal wrote:
> Artur Molchanov <arturmolchanov@gmail.com> wrote:
> > From: Artur Molchanov <artur.molchanov@synesis.ru>
> >
> > Fixes: c5136b15ea36 ("netfilter: bridge: add and use br_nf_hook_thresh")
> >
> > Problem:
> > br_nf_pre_routing_finish() calls itself instead of
> > br_nf_pre_routing_finish_bridge().
> > Due to this bug reverse path filter drops packets that moving through
> > bridge interface.
>
> Indeed, thanks for fixing this!
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net/bridge: Fix dropping packets that moving through bridge interface
2016-12-30 17:22 ` Pablo Neira Ayuso
@ 2017-01-05 7:11 ` Artur Molchanov
0 siblings, 0 replies; 4+ messages in thread
From: Artur Molchanov @ 2017-01-05 7:11 UTC (permalink / raw)
To: Pablo Neira Ayuso, Florian Westphal; +Cc: netfilter-devel
30.12.2016 20:22, Pablo Neira Ayuso wrote:
> On Fri, Dec 30, 2016 at 05:58:11PM +0100, Florian Westphal wrote:
>> Artur Molchanov <arturmolchanov@gmail.com> wrote:
>>> From: Artur Molchanov <artur.molchanov@synesis.ru>
>>>
>>> Fixes: c5136b15ea36 ("netfilter: bridge: add and use br_nf_hook_thresh")
>>>
>>> Problem:
>>> br_nf_pre_routing_finish() calls itself instead of
>>> br_nf_pre_routing_finish_bridge().
>>> Due to this bug reverse path filter drops packets that moving through
>>> bridge interface.
>> Indeed, thanks for fixing this!
> Applied, thanks everyone.
When the fix will be available in upstream?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-05 7:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-30 16:46 [PATCH] net/bridge: Fix dropping packets that moving through bridge interface Artur Molchanov
2016-12-30 16:58 ` Florian Westphal
2016-12-30 17:22 ` Pablo Neira Ayuso
2017-01-05 7:11 ` Artur Molchanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).