netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: netfilter-devel@vger.kernel.org
Subject: [PATCH v2 0/2] segtree: move huge arrays to heap
Date: Mon,  2 Jan 2017 20:54:07 +0100	[thread overview]
Message-ID: <20170102195409.14669-1-oleksandr@natalenko.name> (raw)

While dealing with huge sets, nft may exhaust stack
and trigger segfault. To avoid this, lets move those
huge arrays away from stack to heap.

First patch introduces array allocation helper.

Second patch modifies interval_map_decompose()
function, allocating memory for arrays on head.

Meny thanks to Florian Westphal who helped
to sort this out.

Changelog:

v2: nmemb actually can be 0, so remove that
    assertion

v1: initial submission

Oleksandr Natalenko (2):
  utils: provide array allocation wrapper
  segtree: allocate memory for arrays on heap

 include/utils.h |  1 +
 src/segtree.c   |  8 +++++++-
 src/utils.c     | 10 ++++++++++
 3 files changed, 18 insertions(+), 1 deletion(-)

-- 
2.11.0


             reply	other threads:[~2017-01-02 19:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 19:54 Oleksandr Natalenko [this message]
2017-01-02 19:54 ` [PATCH v2 1/2] utils: provide array allocation wrapper Oleksandr Natalenko
2017-01-02 19:54 ` [PATCH v2 2/2] segtree: allocate memory for arrays on heap Oleksandr Natalenko
2017-01-03  1:54 ` [PATCH v2 0/2] segtree: move huge arrays to heap Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102195409.14669-1-oleksandr@natalenko.name \
    --to=oleksandr@natalenko.name \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).