From: kbuild test robot <lkp@intel.com>
To: Florian Westphal <fw@strlen.de>
Cc: kbuild-all@01.org, netfilter-devel@vger.kernel.org,
netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer storage area
Date: Thu, 5 Jan 2017 14:03:05 +0800 [thread overview]
Message-ID: <201701051342.oqwOKzMG%fengguang.wu@intel.com> (raw)
In-Reply-To: <1483544150-10686-5-git-send-email-fw@strlen.de>
[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]
Hi Florian,
[auto build test WARNING on nf-next/master]
url: https://github.com/0day-ci/linux/commits/Florian-Westphal/netfilter-skbuff-merge-nfctinfo-bits-and-nfct-pointer/20170105-133727
base: https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: x86_64-randconfig-x002-201701 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
net/ipv4/netfilter/nf_defrag_ipv4.c: In function 'ipv4_conntrack_defrag':
>> net/ipv4/netfilter/nf_defrag_ipv4.c:78:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (skb->_nfct && !nf_ct_is_template((struct nf_conn *) skb_nfct(skb)));
^~
net/ipv4/netfilter/nf_defrag_ipv4.c:79:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return NF_ACCEPT;
^~~~~~
vim +/if +78 net/ipv4/netfilter/nf_defrag_ipv4.c
62 }
63
64 static unsigned int ipv4_conntrack_defrag(void *priv,
65 struct sk_buff *skb,
66 const struct nf_hook_state *state)
67 {
68 struct sock *sk = skb->sk;
69
70 if (sk && sk_fullsock(sk) && (sk->sk_family == PF_INET) &&
71 inet_sk(sk)->nodefrag)
72 return NF_ACCEPT;
73
74 #if IS_ENABLED(CONFIG_NF_CONNTRACK)
75 #if !IS_ENABLED(CONFIG_NF_NAT)
76 /* Previously seen (loopback)? Ignore. Do this before
77 fragment check. */
> 78 if (skb->_nfct && !nf_ct_is_template((struct nf_conn *) skb_nfct(skb)));
79 return NF_ACCEPT;
80 #endif
81 #endif
82 /* Gather fragments. */
83 if (ip_is_fragment(ip_hdr(skb))) {
84 enum ip_defrag_users user =
85 nf_ct_defrag_user(state->hook, skb);
86
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 24700 bytes --]
next prev parent reply other threads:[~2017-01-05 6:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 15:35 [PATCH nf-next 0/4] netfilter: skbuff: merge nfctinfo bits and nfct pointer Florian Westphal
2017-01-04 15:35 ` [PATCH nf-next 1/4] netfilter: conntrack: no need to pass ctinfo to error handler Florian Westphal
2017-01-04 15:35 ` [PATCH nf-next 2/4] netfilter: reset netfilter state when duplicating packet Florian Westphal
2017-01-04 15:35 ` [PATCH nf-next 3/4] netfilter: reduce direct skb->nfct usage Florian Westphal
2017-01-04 15:35 ` [PATCH nf-next 4/4] netfilter: merge ctinfo into nfct pointer storage area Florian Westphal
2017-01-05 6:03 ` kbuild test robot [this message]
2017-01-05 8:31 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201701051342.oqwOKzMG%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=fw@strlen.de \
--cc=kbuild-all@01.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).