From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH libnetfilter_cthelper] Use __EXPORTED rather than EXPORT_SYMBOL Date: Mon, 16 Jan 2017 14:30:44 +0100 Message-ID: <20170116133044.GB31271@salvia> References: <20170104223026.33362-1-cernekee@chromium.org> <20170104223026.33362-2-cernekee@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Kevin Cernekee Return-path: Received: from mail.us.es ([193.147.175.20]:57256 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751603AbdAPNau (ORCPT ); Mon, 16 Jan 2017 08:30:50 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id E3849392E03 for ; Mon, 16 Jan 2017 14:30:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id D39F79D690 for ; Mon, 16 Jan 2017 14:30:47 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A72739D696 for ; Mon, 16 Jan 2017 14:30:45 +0100 (CET) Content-Disposition: inline In-Reply-To: <20170104223026.33362-2-cernekee@chromium.org> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Jan 04, 2017 at 02:30:26PM -0800, Kevin Cernekee wrote: > clang is sensitive to the ordering of > __attribute__((visibility("default"))) relative to the function > body. gcc is not. So if we try to re-declare an existing function > with default visibility, clang prints a warning and generates > a broken .so file in which nfct_helper_* are not exported to library > callers. > > Move the attribute up into the function definition to make clang happy. Also applied, thanks.