From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org, Jarno Rajahalme <jarno@ovn.org>,
Victor Julien <lists@inliniac.net>
Subject: Re: [PATCH nf-next] netfilter: ctnetlink: make more information available in DESTROY events
Date: Wed, 18 Jan 2017 16:01:18 +0100 [thread overview]
Message-ID: <20170118150118.GA23289@salvia> (raw)
In-Reply-To: <1484751272-5489-1-git-send-email-fw@strlen.de>
On Wed, Jan 18, 2017 at 03:54:32PM +0100, Florian Westphal wrote:
> destroy events currently don't contain the tcp state info and no
> secmark and conntrack labels.
>
> Quoting Victor:
> "I was hoping to get the last TCP state in a conntrack destroy event,
> however it seems to be unavailable."
>
> Quoting Jarno:
> "I have a use case where we want to log terminating connections, but
> only if a specific label bit is set."
>
> While at it, also include SECMARK in destroy events if one is available.
I'm fine with this.
But to remember the original problem is that netlink bandwidth is
limited, so the more we load the netlink message, the more chances we
have to hit ENOBUFS.
connlabel is optional, so you only get it if needed.
But the protoinfo thing, I would prefer we just dump the state given
this the usecase we have now.
Probably extend ->to_nlattr() to have a bool that indicates if this is
a dump?
next prev parent reply other threads:[~2017-01-18 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 14:54 [PATCH nf-next] netfilter: ctnetlink: make more information available in DESTROY events Florian Westphal
2017-01-18 15:01 ` Pablo Neira Ayuso [this message]
2017-01-18 15:07 ` Florian Westphal
2017-01-18 16:03 ` Pablo Neira Ayuso
2017-01-18 16:18 ` Florian Westphal
2017-01-20 7:51 ` Victor Julien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118150118.GA23289@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=jarno@ovn.org \
--cc=lists@inliniac.net \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).