From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Elise Lennion <elise.lennion@gmail.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 2/2] tests: py: Use stateless option on tests
Date: Wed, 18 Jan 2017 19:02:53 +0100 [thread overview]
Message-ID: <20170118180253.GB24632@salvia> (raw)
In-Reply-To: <20170117154454.GA31287@lennorien.com>
On Tue, Jan 17, 2017 at 01:44:54PM -0200, Elise Lennion wrote:
> To don't trigger false errors because of unrelated traffic on the
> tested machine.
>
> Tests, which have rules with counter and 'ok' result, are updated to
> avoid new Warnings.
Also applied, thanks.
> diff --git a/tests/py/ip/flowtable.t b/tests/py/ip/flowtable.t
> index aea57c3..41d5d3b 100644
> --- a/tests/py/ip/flowtable.t
> +++ b/tests/py/ip/flowtable.t
> @@ -2,4 +2,4 @@
>
> *ip;test-ip;input
>
> -flow table xyz { ip saddr timeout 30s counter packets 0 bytes 0};ok
> +flow table xyz { ip saddr timeout 30s counter};ok
This reminds something: From flow tables, counter, quota, and limit
must always be printed in their stateless version.
A simple way to fix this is to turn stateless_output into unsigned
int, so you can stateless_output++ before printing the statement from
flow_stmt_print().
next prev parent reply other threads:[~2017-01-18 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 15:44 [PATCH nft 2/2] tests: py: Use stateless option on tests Elise Lennion
2017-01-18 18:02 ` Pablo Neira Ayuso [this message]
2017-01-18 18:03 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118180253.GB24632@salvia \
--to=pablo@netfilter.org \
--cc=elise.lennion@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).