From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH nf-next 2/2] netfilter: nft_meta: deal with PACKET_LOOPBACK in netdev family
Date: Wed, 18 Jan 2017 20:33:44 +0100 [thread overview]
Message-ID: <20170118193344.GB14270@salvia> (raw)
In-Reply-To: <1483796035-54792-2-git-send-email-zlpnobody@163.com>
On Sat, Jan 07, 2017 at 09:33:55PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> After adding the following nft rule, then ping 224.0.0.1:
> # nft add rule netdev t c pkttype host counter
>
> The warning complain message will be printed out again and again:
> WARNING: CPU: 0 PID: 10182 at net/netfilter/nft_meta.c:163 \
> nft_meta_get_eval+0x3fe/0x460 [nft_meta]
> [...]
> Call Trace:
> <IRQ>
> dump_stack+0x85/0xc2
> __warn+0xcb/0xf0
> warn_slowpath_null+0x1d/0x20
> nft_meta_get_eval+0x3fe/0x460 [nft_meta]
> nft_do_chain+0xff/0x5e0 [nf_tables]
>
> So we should deal with PACKET_LOOPBACK in netdev family too. For ipv4,
> convert it to PACKET_BROADCAST/MULTICAST according to the destination
> address's type; For ipv6, convert it to PACKET_MULTICAST directly.
Also applied, thanks.
next prev parent reply other threads:[~2017-01-18 19:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 13:33 [PATCH nf-next 1/2] netfilter: pkttype: unnecessary to check ipv6 multicast address Liping Zhang
2017-01-07 13:33 ` [PATCH nf-next 2/2] netfilter: nft_meta: deal with PACKET_LOOPBACK in netdev family Liping Zhang
2017-01-18 19:33 ` Pablo Neira Ayuso [this message]
2017-01-18 19:33 ` [PATCH nf-next 1/2] netfilter: pkttype: unnecessary to check ipv6 multicast address Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170118193344.GB14270@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).