From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: ejcaruso@chromium.org, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH conntrack-tools] conntrackd: cthelper: Don't leak nat_tuple
Date: Wed, 1 Feb 2017 18:04:24 +0100 [thread overview]
Message-ID: <20170201170424.GC5052@salvia> (raw)
In-Reply-To: <20170127004424.16494-1-cernekee@chromium.org>
On Thu, Jan 26, 2017 at 04:44:24PM -0800, Kevin Cernekee wrote:
> nfexp_set_attr() copies |nat_tuple| rather than taking ownership, so
> it should be freed at the end of the loop. Some of the other helpers
> (like rpc.c) do this, but it is missing here.
Also applied, thanks!
prev parent reply other threads:[~2017-02-01 17:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 0:44 [PATCH conntrack-tools] conntrackd: cthelper: Don't leak nat_tuple Kevin Cernekee
2017-02-01 17:04 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201170424.GC5052@salvia \
--to=pablo@netfilter.org \
--cc=cernekee@chromium.org \
--cc=ejcaruso@chromium.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).