From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Kevin Cernekee <cernekee@chromium.org>
Cc: dianders@chromium.org, davem@davemloft.net,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing
Date: Mon, 6 Feb 2017 12:44:43 +0100 [thread overview]
Message-ID: <20170206114443.GB15498@salvia> (raw)
In-Reply-To: <20170126224944.29047-2-cernekee@chromium.org>
On Thu, Jan 26, 2017 at 02:49:44PM -0800, Kevin Cernekee wrote:
> Prior to Linux 4.4, it was usually harmless to send a CTA_HELP attribute
> containing the name of the current helper. That is no longer the case:
> as of Linux 4.4, if ctnetlink_change_helper() returns an error from
> the ct->master check, processing of the request will fail, skipping the
> NFQA_EXP attribute (if present).
>
> This patch changes the behavior to improve compatibility with user
> programs that expect the kernel interface to work the way it did prior
> to Linux 4.4. If a user program specifies CTA_HELP but the argument
> matches the current conntrack helper name, ignore it instead of generating
> an error.
Also applied, thanks Kevin.
next prev parent reply other threads:[~2017-02-06 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 22:49 [PATCH V2 1/2] netfilter: ctnetlink: Fix regression in CTA_STATUS processing Kevin Cernekee
2017-01-26 22:49 ` [PATCH V2 2/2] netfilter: ctnetlink: Fix regression in CTA_HELP processing Kevin Cernekee
2017-02-06 11:44 ` Pablo Neira Ayuso [this message]
2017-02-06 11:44 ` [PATCH V2 1/2] netfilter: ctnetlink: Fix regression in CTA_STATUS processing Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170206114443.GB15498@salvia \
--to=pablo@netfilter.org \
--cc=cernekee@chromium.org \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).