From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH] Revert "net: Remove state argument from skb_find_text()" Date: Tue, 7 Feb 2017 13:36:16 +0100 Message-ID: <20170207123616.GA2607@salvia> References: <1486273710-18457-1-git-send-email-igor.pylypiv@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "David S . Miller" , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org To: Igor Pylypiv Return-path: Content-Disposition: inline In-Reply-To: <1486273710-18457-1-git-send-email-igor.pylypiv@gmail.com> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Sat, Feb 04, 2017 at 09:48:30PM -0800, Igor Pylypiv wrote: > This reverts commit 059a2440fd3cf4ec57735db2c0a90401cde84fca. > > Textsearch state parameter should be passed by pointer because > its resulting value is needed for call to textsearch_next(). You're right this renders textsearch_next() useless. But I remember David took this one time ago because there are no clients for textsearch_next() in the tree, apart from textsearch_find(). Am I missing anything? Thanks.