From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org, fw@strlen.de, mm@skelett.io
Subject: Re: [PATCH nf-next v2,1/2] netfilter: nft_exthdr: Add support for existence check
Date: Tue, 7 Feb 2017 23:47:05 +0100 [thread overview]
Message-ID: <20170207224705.GL22796@orbyte.nwl.cc> (raw)
In-Reply-To: <1486498828-17936-1-git-send-email-pablo@netfilter.org>
Hi,
On Tue, Feb 07, 2017 at 09:20:27PM +0100, Pablo Neira Ayuso wrote:
> From: Phil Sutter <phil@nwl.cc>
>
> If NFT_EXTHDR_F_PRESENT is set, exthdr will not copy any header field
> data into *dest, but instead set it to 1 if the header is found and 0
> otherwise.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> ---
> @Phil: I have enhanced your patch shrink flags to u8, also check for
> unexisting flags. As well as the sparse warning. Please review
> if this looks good to you. Thanks.
Yes, looks good to me!
Thanks, Phil
prev parent reply other threads:[~2017-02-07 22:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 20:20 [PATCH nf-next v2,1/2] netfilter: nft_exthdr: Add support for existence check Pablo Neira Ayuso
2017-02-07 20:20 ` [PATCH nf-next v2,2/2] netfilter: nft_exthdr: add TCP option matching Pablo Neira Ayuso
2017-02-07 22:48 ` Phil Sutter
2017-02-07 22:47 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207224705.GL22796@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=fw@strlen.de \
--cc=mm@skelett.io \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).