From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jarno Rajahalme <jarno@ovn.org>
Cc: netfilter-devel@vger.kernel.org, fgao@ikuai8.com
Subject: Re: [PATCH nf 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success.
Date: Sat, 25 Feb 2017 13:34:19 +0100 [thread overview]
Message-ID: <20170225123419.GA27078@salvia> (raw)
In-Reply-To: <1487898534-64560-1-git-send-email-jarno@ovn.org>
On Thu, Feb 23, 2017 at 05:08:53PM -0800, Jarno Rajahalme wrote:
> Commit 4dee62b1b9b4 ("netfilter: nf_ct_expect: nf_ct_expect_insert()
> returns void") inadvertently changed the successful return value of
> nf_ct_expect_related_report() from 0 to 1, which caused openvswitch
> conntrack integration fail in FTP test cases.
>
> Fix this by always returning zero on the success code path.
Applied, thanks Jarno.
prev parent reply other threads:[~2017-02-25 12:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 1:08 [PATCH nf 1/2] netfilter: nf_ct_expect: nf_ct_expect_related_report(): Return zero on success Jarno Rajahalme
2017-02-24 1:08 ` [PATCH nf 2/2] netfilter: nf_ct_expect: Change __nf_ct_expect_check() return value Jarno Rajahalme
2017-02-25 12:35 ` Pablo Neira Ayuso
2017-02-25 12:34 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170225123419.GA27078@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=jarno@ovn.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).