From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Alexander Alemayhu <alexander@alemayhu.com>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] mnl: continue monitor if errno is ESRCH
Date: Wed, 1 Mar 2017 16:18:00 +0100 [thread overview]
Message-ID: <20170301151800.GA1044@salvia> (raw)
In-Reply-To: <20170301145227.GA10448@gmail.com>
On Wed, Mar 01, 2017 at 03:52:27PM +0100, Alexander Alemayhu wrote:
> On Wed, Mar 01, 2017 at 12:41:40PM +0100, Pablo Neira Ayuso wrote:
> >
> > Actually, this patch would be better. All return values of these
> > notify function are ignored, so we can turned it into void.
>
> Monitor seems to work as expected and does not exit with this patch.
> Should all of the tests pass with this? Currently seeing
>
> I: results: [OK] 58 [FAILED] 49 [TOTAL] 107
Hm, I'm hitting this here:
I: results: [OK] 107 [FAILED] 0 [TOTAL] 107
Running nft git HEAD and nf.git kernel.
If you're on the same page as me, would you run some test individually
to see what is breaking?
Thanks.
next prev parent reply other threads:[~2017-03-01 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 16:30 [PATCH nft] mnl: continue monitor if errno is ESRCH Alexander Alemayhu
2017-02-26 20:24 ` Pablo Neira Ayuso
2017-03-01 11:21 ` Pablo Neira Ayuso
2017-03-01 11:41 ` Pablo Neira Ayuso
2017-03-01 14:52 ` Alexander Alemayhu
2017-03-01 15:18 ` Pablo Neira Ayuso [this message]
2017-03-01 18:27 ` Alexander Alemayhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301151800.GA1044@salvia \
--to=pablo@netfilter.org \
--cc=alexander@alemayhu.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).