* [PATCH nft] mnl: continue monitor if errno is ESRCH @ 2017-02-26 16:30 Alexander Alemayhu 2017-02-26 20:24 ` Pablo Neira Ayuso 0 siblings, 1 reply; 7+ messages in thread From: Alexander Alemayhu @ 2017-02-26 16:30 UTC (permalink / raw) To: netfilter-devel; +Cc: Alexander Alemayhu Running the test cases in the shell directory while running nft monitor results in nft exiting with '# ERROR: No such process'. The minimal steps where I could reproduce is: nft monitor # shell 1 run-tests.sh testcases/sets/0011add_many_elements_0 # shell 2 Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> --- Not sure if this is considered a fix or desired behaviour, but I was not expecting monitor to exit like this. src/mnl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mnl.c b/src/mnl.c index 295dd84a5840..a0066a28b44f 100644 --- a/src/mnl.c +++ b/src/mnl.c @@ -1129,7 +1129,10 @@ int mnl_nft_event_listener(struct mnl_socket *nf_sock, printf("# ERROR: We lost some netlink events!\n"); continue; } + fprintf(stdout, "# ERROR: %s\n", strerror(errno)); + if (errno == ESRCH) + continue; break; } ret = mnl_cb_run(buf, ret, 0, 0, cb, cb_data); -- 2.9.3 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH nft] mnl: continue monitor if errno is ESRCH 2017-02-26 16:30 [PATCH nft] mnl: continue monitor if errno is ESRCH Alexander Alemayhu @ 2017-02-26 20:24 ` Pablo Neira Ayuso 2017-03-01 11:21 ` Pablo Neira Ayuso 0 siblings, 1 reply; 7+ messages in thread From: Pablo Neira Ayuso @ 2017-02-26 20:24 UTC (permalink / raw) To: Alexander Alemayhu; +Cc: netfilter-devel On Sun, Feb 26, 2017 at 05:30:58PM +0100, Alexander Alemayhu wrote: > Running the test cases in the shell directory while running nft monitor results > in nft exiting with '# ERROR: No such process'. The minimal steps where I could > reproduce is: > > nft monitor # shell 1 > run-tests.sh testcases/sets/0011add_many_elements_0 # shell 2 > > Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> > --- > > Not sure if this is considered a fix or desired behaviour, but I was not > expecting monitor to exit like this. > > src/mnl.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mnl.c b/src/mnl.c > index 295dd84a5840..a0066a28b44f 100644 > --- a/src/mnl.c > +++ b/src/mnl.c > @@ -1129,7 +1129,10 @@ int mnl_nft_event_listener(struct mnl_socket *nf_sock, > printf("# ERROR: We lost some netlink events!\n"); > continue; > } > + > fprintf(stdout, "# ERROR: %s\n", strerror(errno)); > + if (errno == ESRCH) > + continue; It seems netlink is returning ESRCH when the number of events is high, however, it should hit ENOBUFS instead, this is strange. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nft] mnl: continue monitor if errno is ESRCH 2017-02-26 20:24 ` Pablo Neira Ayuso @ 2017-03-01 11:21 ` Pablo Neira Ayuso 2017-03-01 11:41 ` Pablo Neira Ayuso 0 siblings, 1 reply; 7+ messages in thread From: Pablo Neira Ayuso @ 2017-03-01 11:21 UTC (permalink / raw) To: Alexander Alemayhu; +Cc: netfilter-devel [-- Attachment #1: Type: text/plain, Size: 1480 bytes --] On Sun, Feb 26, 2017 at 09:24:10PM +0100, Pablo Neira Ayuso wrote: > On Sun, Feb 26, 2017 at 05:30:58PM +0100, Alexander Alemayhu wrote: > > Running the test cases in the shell directory while running nft monitor results > > in nft exiting with '# ERROR: No such process'. The minimal steps where I could > > reproduce is: > > > > nft monitor # shell 1 > > run-tests.sh testcases/sets/0011add_many_elements_0 # shell 2 > > > > Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> > > --- > > > > Not sure if this is considered a fix or desired behaviour, but I was not > > expecting monitor to exit like this. > > > > src/mnl.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/src/mnl.c b/src/mnl.c > > index 295dd84a5840..a0066a28b44f 100644 > > --- a/src/mnl.c > > +++ b/src/mnl.c > > @@ -1129,7 +1129,10 @@ int mnl_nft_event_listener(struct mnl_socket *nf_sock, > > printf("# ERROR: We lost some netlink events!\n"); > > continue; > > } > > + > > fprintf(stdout, "# ERROR: %s\n", strerror(errno)); > > + if (errno == ESRCH) > > + continue; > > It seems netlink is returning ESRCH when the number of events is high, > however, it should hit ENOBUFS instead, this is strange. We at least need this fix from kernelspace. Basically, the idea is to set socket error to ENOBUFS so the event listener knows that we're losing events, this is the correct way to report this in terms of netlink semantics. Would you give it a try? [-- Attachment #2: x.patch --] [-- Type: text/x-diff, Size: 3329 bytes --] diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index ff7304ae58ac..76b79bd0f25a 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -486,10 +486,11 @@ static int nf_tables_table_notify(const struct nft_ctx *ctx, int event) ctx->report, GFP_KERNEL); err: if (err < 0) { - nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, - err); + if (nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, + -ENOBUFS) > 0) + return -ENOBUFS; } - return err; + return 0; } static int nf_tables_dump_tables(struct sk_buff *skb, @@ -1076,10 +1077,11 @@ static int nf_tables_chain_notify(const struct nft_ctx *ctx, int event) ctx->report, GFP_KERNEL); err: if (err < 0) { - nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, - err); + if (nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, + -ENOBUFS) > 0) + return -ENOBUFS; } - return err; + return 0; } static int nf_tables_dump_chains(struct sk_buff *skb, @@ -1962,10 +1964,11 @@ static int nf_tables_rule_notify(const struct nft_ctx *ctx, ctx->report, GFP_KERNEL); err: if (err < 0) { - nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, - err); + if (nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, + -ENOBUFS) > 0) + return -ENOBUFS; } - return err; + return 0; } struct nft_rule_dump_ctx { @@ -2722,9 +2725,12 @@ static int nf_tables_set_notify(const struct nft_ctx *ctx, err = nfnetlink_send(skb, ctx->net, portid, NFNLGRP_NFTABLES, ctx->report, gfp_flags); err: - if (err < 0) - nfnetlink_set_err(ctx->net, portid, NFNLGRP_NFTABLES, err); - return err; + if (err < 0) { + if (nfnetlink_set_err(ctx->net, portid, NFNLGRP_NFTABLES, + -ENOBUFS) > 0) + return -ENOBUFS; + } + return 0; } static int nf_tables_dump_sets(struct sk_buff *skb, struct netlink_callback *cb) @@ -3532,9 +3538,12 @@ static int nf_tables_setelem_notify(const struct nft_ctx *ctx, err = nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, ctx->report, GFP_KERNEL); err: - if (err < 0) - nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, err); - return err; + if (err < 0) { + if (nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, + -ENOBUFS) > 0) + return -ENOBUFS; + } + return 0; } static struct nft_trans *nft_trans_elem_alloc(struct nft_ctx *ctx, @@ -4502,9 +4511,11 @@ int nft_obj_notify(struct net *net, struct nft_table *table, err = nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, report, gfp); err: if (err < 0) { - nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, err); + if (nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, + -ENOBUFS) > 0) + return -ENOBUFS; } - return err; + return 0; } EXPORT_SYMBOL_GPL(nft_obj_notify); @@ -4569,10 +4580,11 @@ static int nf_tables_gen_notify(struct net *net, struct sk_buff *skb, int event) NFNLGRP_NFTABLES, nlmsg_report(nlh), GFP_KERNEL); err: if (err < 0) { - nfnetlink_set_err(net, NETLINK_CB(skb).portid, NFNLGRP_NFTABLES, - err); + if (nfnetlink_set_err(net, NETLINK_CB(skb).portid, + NFNLGRP_NFTABLES, -ENOBUFS) > 0) + return -ENOBUFS; } - return err; + return 0; } static int nf_tables_getgen(struct net *net, struct sock *nlsk, ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH nft] mnl: continue monitor if errno is ESRCH 2017-03-01 11:21 ` Pablo Neira Ayuso @ 2017-03-01 11:41 ` Pablo Neira Ayuso 2017-03-01 14:52 ` Alexander Alemayhu 0 siblings, 1 reply; 7+ messages in thread From: Pablo Neira Ayuso @ 2017-03-01 11:41 UTC (permalink / raw) To: Alexander Alemayhu; +Cc: netfilter-devel [-- Attachment #1: Type: text/plain, Size: 1755 bytes --] On Wed, Mar 01, 2017 at 12:21:03PM +0100, Pablo Neira Ayuso wrote: > On Sun, Feb 26, 2017 at 09:24:10PM +0100, Pablo Neira Ayuso wrote: > > On Sun, Feb 26, 2017 at 05:30:58PM +0100, Alexander Alemayhu wrote: > > > Running the test cases in the shell directory while running nft monitor results > > > in nft exiting with '# ERROR: No such process'. The minimal steps where I could > > > reproduce is: > > > > > > nft monitor # shell 1 > > > run-tests.sh testcases/sets/0011add_many_elements_0 # shell 2 > > > > > > Signed-off-by: Alexander Alemayhu <alexander@alemayhu.com> > > > --- > > > > > > Not sure if this is considered a fix or desired behaviour, but I was not > > > expecting monitor to exit like this. > > > > > > src/mnl.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/src/mnl.c b/src/mnl.c > > > index 295dd84a5840..a0066a28b44f 100644 > > > --- a/src/mnl.c > > > +++ b/src/mnl.c > > > @@ -1129,7 +1129,10 @@ int mnl_nft_event_listener(struct mnl_socket *nf_sock, > > > printf("# ERROR: We lost some netlink events!\n"); > > > continue; > > > } > > > + > > > fprintf(stdout, "# ERROR: %s\n", strerror(errno)); > > > + if (errno == ESRCH) > > > + continue; > > > > It seems netlink is returning ESRCH when the number of events is high, > > however, it should hit ENOBUFS instead, this is strange. > > We at least need this fix from kernelspace. > > Basically, the idea is to set socket error to ENOBUFS so the event > listener knows that we're losing events, this is the correct way to > report this in terms of netlink semantics. > > Would you give it a try? Actually, this patch would be better. All return values of these notify function are ignored, so we can turned it into void. [-- Attachment #2: x.patch --] [-- Type: text/x-diff, Size: 9255 bytes --] diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index ac84686aaafb..2aa8a9d80fbe 100644 --- a/include/net/netfilter/nf_tables.h +++ b/include/net/netfilter/nf_tables.h @@ -988,9 +988,9 @@ struct nft_object *nf_tables_obj_lookup(const struct nft_table *table, const struct nlattr *nla, u32 objtype, u8 genmask); -int nft_obj_notify(struct net *net, struct nft_table *table, - struct nft_object *obj, u32 portid, u32 seq, - int event, int family, int report, gfp_t gfp); +void nft_obj_notify(struct net *net, struct nft_table *table, + struct nft_object *obj, u32 portid, u32 seq, + int event, int family, int report, gfp_t gfp); /** * struct nft_object_type - stateful object type diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index ff7304ae58ac..dcd59b8518af 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -461,16 +461,15 @@ static int nf_tables_fill_table_info(struct sk_buff *skb, struct net *net, return -1; } -static int nf_tables_table_notify(const struct nft_ctx *ctx, int event) +static void nf_tables_table_notify(const struct nft_ctx *ctx, int event) { struct sk_buff *skb; int err; if (!ctx->report && !nfnetlink_has_listeners(ctx->net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); if (skb == NULL) goto err; @@ -484,12 +483,12 @@ static int nf_tables_table_notify(const struct nft_ctx *ctx, int event) err = nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES, ctx->report, GFP_KERNEL); + if (err < 0) + goto err; + + return; err: - if (err < 0) { - nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, - err); - } - return err; + nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS); } static int nf_tables_dump_tables(struct sk_buff *skb, @@ -1050,16 +1049,15 @@ static int nf_tables_fill_chain_info(struct sk_buff *skb, struct net *net, return -1; } -static int nf_tables_chain_notify(const struct nft_ctx *ctx, int event) +static void nf_tables_chain_notify(const struct nft_ctx *ctx, int event) { struct sk_buff *skb; int err; if (!ctx->report && !nfnetlink_has_listeners(ctx->net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); if (skb == NULL) goto err; @@ -1074,12 +1072,12 @@ static int nf_tables_chain_notify(const struct nft_ctx *ctx, int event) err = nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES, ctx->report, GFP_KERNEL); + if (err < 0) + goto err; + + return; err: - if (err < 0) { - nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, - err); - } - return err; + nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS); } static int nf_tables_dump_chains(struct sk_buff *skb, @@ -1934,18 +1932,16 @@ static int nf_tables_fill_rule_info(struct sk_buff *skb, struct net *net, return -1; } -static int nf_tables_rule_notify(const struct nft_ctx *ctx, - const struct nft_rule *rule, - int event) +static void nf_tables_rule_notify(const struct nft_ctx *ctx, + const struct nft_rule *rule, int event) { struct sk_buff *skb; int err; if (!ctx->report && !nfnetlink_has_listeners(ctx->net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); if (skb == NULL) goto err; @@ -1960,12 +1956,12 @@ static int nf_tables_rule_notify(const struct nft_ctx *ctx, err = nfnetlink_send(skb, ctx->net, ctx->portid, NFNLGRP_NFTABLES, ctx->report, GFP_KERNEL); + if (err < 0) + goto err; + + return; err: - if (err < 0) { - nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, - err); - } - return err; + nfnetlink_set_err(ctx->net, ctx->portid, NFNLGRP_NFTABLES, -ENOBUFS); } struct nft_rule_dump_ctx { @@ -2696,9 +2692,9 @@ static int nf_tables_fill_set(struct sk_buff *skb, const struct nft_ctx *ctx, return -1; } -static int nf_tables_set_notify(const struct nft_ctx *ctx, - const struct nft_set *set, - int event, gfp_t gfp_flags) +static void nf_tables_set_notify(const struct nft_ctx *ctx, + const struct nft_set *set, int event, + gfp_t gfp_flags) { struct sk_buff *skb; u32 portid = ctx->portid; @@ -2706,9 +2702,8 @@ static int nf_tables_set_notify(const struct nft_ctx *ctx, if (!ctx->report && !nfnetlink_has_listeners(ctx->net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb = nlmsg_new(NLMSG_GOODSIZE, gfp_flags); if (skb == NULL) goto err; @@ -2721,10 +2716,12 @@ static int nf_tables_set_notify(const struct nft_ctx *ctx, err = nfnetlink_send(skb, ctx->net, portid, NFNLGRP_NFTABLES, ctx->report, gfp_flags); -err: if (err < 0) - nfnetlink_set_err(ctx->net, portid, NFNLGRP_NFTABLES, err); - return err; + goto err; + + return; +err: + nfnetlink_set_err(ctx->net, portid, NFNLGRP_NFTABLES, -ENOBUFS); } static int nf_tables_dump_sets(struct sk_buff *skb, struct netlink_callback *cb) @@ -3504,10 +3501,10 @@ static int nf_tables_fill_setelem_info(struct sk_buff *skb, return -1; } -static int nf_tables_setelem_notify(const struct nft_ctx *ctx, - const struct nft_set *set, - const struct nft_set_elem *elem, - int event, u16 flags) +static void nf_tables_setelem_notify(const struct nft_ctx *ctx, + const struct nft_set *set, + const struct nft_set_elem *elem, + int event, u16 flags) { struct net *net = ctx->net; u32 portid = ctx->portid; @@ -3515,9 +3512,8 @@ static int nf_tables_setelem_notify(const struct nft_ctx *ctx, int err; if (!ctx->report && !nfnetlink_has_listeners(net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); if (skb == NULL) goto err; @@ -3531,10 +3527,12 @@ static int nf_tables_setelem_notify(const struct nft_ctx *ctx, err = nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, ctx->report, GFP_KERNEL); -err: if (err < 0) - nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, err); - return err; + goto err; + + return; +err: + nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, -ENOBUFS); } static struct nft_trans *nft_trans_elem_alloc(struct nft_ctx *ctx, @@ -4476,18 +4474,17 @@ static int nf_tables_delobj(struct net *net, struct sock *nlsk, return nft_delobj(&ctx, obj); } -int nft_obj_notify(struct net *net, struct nft_table *table, - struct nft_object *obj, u32 portid, u32 seq, int event, - int family, int report, gfp_t gfp) +void nft_obj_notify(struct net *net, struct nft_table *table, + struct nft_object *obj, u32 portid, u32 seq, int event, + int family, int report, gfp_t gfp) { struct sk_buff *skb; int err; if (!report && !nfnetlink_has_listeners(net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb = nlmsg_new(NLMSG_GOODSIZE, gfp); if (skb == NULL) goto err; @@ -4500,20 +4497,20 @@ int nft_obj_notify(struct net *net, struct nft_table *table, } err = nfnetlink_send(skb, net, portid, NFNLGRP_NFTABLES, report, gfp); + if (err < 0) + goto err; + + return; err: - if (err < 0) { - nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, err); - } - return err; + nfnetlink_set_err(net, portid, NFNLGRP_NFTABLES, -ENOBUFS); } EXPORT_SYMBOL_GPL(nft_obj_notify); -static int nf_tables_obj_notify(const struct nft_ctx *ctx, - struct nft_object *obj, int event) +static void nf_tables_obj_notify(const struct nft_ctx *ctx, + struct nft_object *obj, int event) { - return nft_obj_notify(ctx->net, ctx->table, obj, ctx->portid, - ctx->seq, event, ctx->afi->family, ctx->report, - GFP_KERNEL); + nft_obj_notify(ctx->net, ctx->table, obj, ctx->portid, ctx->seq, event, + ctx->afi->family, ctx->report, GFP_KERNEL); } static int nf_tables_fill_gen_info(struct sk_buff *skb, struct net *net, @@ -4543,7 +4540,8 @@ static int nf_tables_fill_gen_info(struct sk_buff *skb, struct net *net, return -EMSGSIZE; } -static int nf_tables_gen_notify(struct net *net, struct sk_buff *skb, int event) +static void nf_tables_gen_notify(struct net *net, struct sk_buff *skb, + int event) { struct nlmsghdr *nlh = nlmsg_hdr(skb); struct sk_buff *skb2; @@ -4551,9 +4549,8 @@ static int nf_tables_gen_notify(struct net *net, struct sk_buff *skb, int event) if (nlmsg_report(nlh) && !nfnetlink_has_listeners(net, NFNLGRP_NFTABLES)) - return 0; + return; - err = -ENOBUFS; skb2 = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL); if (skb2 == NULL) goto err; @@ -4567,12 +4564,13 @@ static int nf_tables_gen_notify(struct net *net, struct sk_buff *skb, int event) err = nfnetlink_send(skb2, net, NETLINK_CB(skb).portid, NFNLGRP_NFTABLES, nlmsg_report(nlh), GFP_KERNEL); + if (err < 0) + goto err; + + return; err: - if (err < 0) { - nfnetlink_set_err(net, NETLINK_CB(skb).portid, NFNLGRP_NFTABLES, - err); - } - return err; + nfnetlink_set_err(net, NETLINK_CB(skb).portid, NFNLGRP_NFTABLES, + -ENOBUFS); } static int nf_tables_getgen(struct net *net, struct sock *nlsk, ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH nft] mnl: continue monitor if errno is ESRCH 2017-03-01 11:41 ` Pablo Neira Ayuso @ 2017-03-01 14:52 ` Alexander Alemayhu 2017-03-01 15:18 ` Pablo Neira Ayuso 0 siblings, 1 reply; 7+ messages in thread From: Alexander Alemayhu @ 2017-03-01 14:52 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: netfilter-devel On Wed, Mar 01, 2017 at 12:41:40PM +0100, Pablo Neira Ayuso wrote: > > Actually, this patch would be better. All return values of these > notify function are ignored, so we can turned it into void. Monitor seems to work as expected and does not exit with this patch. Should all of the tests pass with this? Currently seeing I: results: [OK] 58 [FAILED] 49 [TOTAL] 107 Thanks. -- Mit freundlichen Grüßen Alexander Alemayhu ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nft] mnl: continue monitor if errno is ESRCH 2017-03-01 14:52 ` Alexander Alemayhu @ 2017-03-01 15:18 ` Pablo Neira Ayuso 2017-03-01 18:27 ` Alexander Alemayhu 0 siblings, 1 reply; 7+ messages in thread From: Pablo Neira Ayuso @ 2017-03-01 15:18 UTC (permalink / raw) To: Alexander Alemayhu; +Cc: netfilter-devel On Wed, Mar 01, 2017 at 03:52:27PM +0100, Alexander Alemayhu wrote: > On Wed, Mar 01, 2017 at 12:41:40PM +0100, Pablo Neira Ayuso wrote: > > > > Actually, this patch would be better. All return values of these > > notify function are ignored, so we can turned it into void. > > Monitor seems to work as expected and does not exit with this patch. > Should all of the tests pass with this? Currently seeing > > I: results: [OK] 58 [FAILED] 49 [TOTAL] 107 Hm, I'm hitting this here: I: results: [OK] 107 [FAILED] 0 [TOTAL] 107 Running nft git HEAD and nf.git kernel. If you're on the same page as me, would you run some test individually to see what is breaking? Thanks. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH nft] mnl: continue monitor if errno is ESRCH 2017-03-01 15:18 ` Pablo Neira Ayuso @ 2017-03-01 18:27 ` Alexander Alemayhu 0 siblings, 0 replies; 7+ messages in thread From: Alexander Alemayhu @ 2017-03-01 18:27 UTC (permalink / raw) To: Pablo Neira Ayuso; +Cc: netfilter-devel On Wed, Mar 01, 2017 at 04:18:00PM +0100, Pablo Neira Ayuso wrote: > Hm, I'm hitting this here: > > I: results: [OK] 107 [FAILED] 0 [TOTAL] 107 > > Running nft git HEAD and nf.git kernel. > See no failures with HEAD. Suspect I misconfigured earlier, sorry for the noise. -- Mit freundlichen Grüßen Alexander Alemayhu ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-03-02 2:00 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-26 16:30 [PATCH nft] mnl: continue monitor if errno is ESRCH Alexander Alemayhu 2017-02-26 20:24 ` Pablo Neira Ayuso 2017-03-01 11:21 ` Pablo Neira Ayuso 2017-03-01 11:41 ` Pablo Neira Ayuso 2017-03-01 14:52 ` Alexander Alemayhu 2017-03-01 15:18 ` Pablo Neira Ayuso 2017-03-01 18:27 ` Alexander Alemayhu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).