From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
Gao Feng <fgao@ikuai8.com>,
linux-kernel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] netfilter: nf_conntrack_sip: fix wrong memory initialisation
Date: Fri, 3 Mar 2017 13:27:18 +0100 [thread overview]
Message-ID: <20170303122718.GA15498@salvia> (raw)
In-Reply-To: <20170301143327.2C90B6BD30@localhost.localdomain>
On Wed, Mar 01, 2017 at 03:33:26PM +0100, Christophe Leroy wrote:
> In commit 82de0be6862cd ("netfilter: Add helper array
> register/unregister functions"),
> struct nf_conntrack_helper sip[MAX_PORTS][4] was changed to
> sip[MAX_PORTS * 4], so the memory init should have been changed to
> memset(&sip[4 * i], 0, 4 * sizeof(sip[i]));
>
> But as the sip[] table is allocated in the BSS, it is already set to 0
Applied, thanks.
prev parent reply other threads:[~2017-03-03 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 14:33 [PATCH] netfilter: nf_conntrack_sip: fix wrong memory initialisation Christophe Leroy
2017-03-01 22:46 ` Gao Feng
2017-03-03 12:27 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303122718.GA15498@salvia \
--to=pablo@netfilter.org \
--cc=christophe.leroy@c-s.fr \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fgao@ikuai8.com \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).