From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nat: remove incorrect debug assert
Date: Fri, 3 Mar 2017 13:47:17 +0100 [thread overview]
Message-ID: <20170303124717.GA29312@salvia> (raw)
In-Reply-To: <20170303124404.GB29213@breakpoint.cc>
On Fri, Mar 03, 2017 at 01:44:04PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > > However, changing test to if (iph->frag_off) return -NF_ACCEPT seems
> > > wrong too because we have enough info to track. OTOH, this only happens
> > > with HDRINCL+raw socket so perhaps we shouldn't care about this and
> > > just change ipv4 l3 tracker to ignore all packets w. iph->frag_off set.
> >
> > Florian, unless you rise your hand, I'm going to take this patch so we
> > at least fix splats here. I still have the impression that this
> > setsockopt() option and its interaction with netfilter is broken at
> > many levels.
>
> Hmmm, I think we should disable tracking of all fragmented packets,
> or at least disable NAT of all fragmented packets.
>
> If we NAT 1st packet only then frag reasm won't complete anyway.
Right. Would you give a shoot at this? If you do, I'd appreciate.
Thanks.
next prev parent reply other threads:[~2017-03-03 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 22:14 [PATCH nf] netfilter: nat: remove incorrect debug assert Florian Westphal
2017-02-21 14:09 ` Pablo Neira Ayuso
2017-02-21 14:40 ` Florian Westphal
2017-02-21 15:54 ` Pablo Neira Ayuso
2017-03-03 11:55 ` Pablo Neira Ayuso
2017-03-03 12:44 ` Florian Westphal
2017-03-03 12:47 ` Pablo Neira Ayuso [this message]
2017-03-03 19:40 ` Jozsef Kadlecsik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303124717.GA29312@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).