[PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[Kaarle Ritvanen]

Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
---
 ulogd.logrotate | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ulogd.logrotate b/ulogd.logrotate
index b3fb6d1..a865353 100644
--- a/ulogd.logrotate
+++ b/ulogd.logrotate
@@ -1,4 +1,4 @@
-/var/log/ulogd.log /var/log/ulogd.syslogemu /var/log/ulogd.pktlog /var/log/ulogd.pcap {
+/var/log/ulogd*.log {
     missingok
     sharedscripts
     postrotate
-- 
2.9.3

Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[Pablo Neira Ayuso]

I'll let Eric decide to this small update.

On Fri, Feb 03, 2017 at 01:24:27PM +0200, Kaarle Ritvanen wrote:
> Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
> ---
>  ulogd.logrotate | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ulogd.logrotate b/ulogd.logrotate
> index b3fb6d1..a865353 100644
> --- a/ulogd.logrotate
> +++ b/ulogd.logrotate
> @@ -1,4 +1,4 @@
> -/var/log/ulogd.log /var/log/ulogd.syslogemu /var/log/ulogd.pktlog /var/log/ulogd.pcap {
> +/var/log/ulogd*.log {
>      missingok
>      sharedscripts
>      postrotate
> -- 
> 2.9.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[Arturo Borrero Gonzalez]

On 12 February 2017 at 15:09, Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> I'll let Eric decide to this small update.
>

Perhaps it would be good idea to drop this file from our tree and let
distros adjust this.

Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[Eric Leblond]

Hello,

On Fri, 2017-02-03 at 13:24 +0200, Kaarle Ritvanen wrote:
> Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
> ---
>  ulogd.logrotate | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/ulogd.logrotate b/ulogd.logrotate
> index b3fb6d1..a865353 100644
> --- a/ulogd.logrotate
> +++ b/ulogd.logrotate
> @@ -1,4 +1,4 @@
> -/var/log/ulogd.log /var/log/ulogd.syslogemu /var/log/ulogd.pktlog 

This is not correct. All the listed files are default value for various
existing output modules so we should keep them.

> /var/log/ulogd.pcap {
> +/var/log/ulogd*.log {
>      missingok
>      sharedscripts
>      postrotate

PS to Kaarle: resending because initial mail did not reach the ML.

BR,
-- 
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/

Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[Kaarle Ritvanen]

On Sun, 12 Feb 2017, Eric Leblond wrote:

> This is not correct. All the listed files are default value for various 
> existing output modules so we should keep them.

Sorry, I was looking at the default configuration file. Currently, the 
default configuration file is inconsistent with the module defaults. I 
think it would be good to harmonize all these, so I posted a couple of 
patches:

Harmonize default log files:
http://marc.info/?l=netfilter-devel&m=148697928328626&w=2

Add missing default log files to logrotate configuration:
http://marc.info/?l=netfilter-devel&m=148697928528629&w=2

I wish somebody would comment these.

BR,
Kaarle

Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf

[Pablo Neira Ayuso]

On Mon, Mar 06, 2017 at 07:06:51PM +0200, Kaarle Ritvanen wrote:
> On Sun, 12 Feb 2017, Eric Leblond wrote:
> 
> > This is not correct. All the listed files are default value for various 
> > existing output modules so we should keep them.
> 
> Sorry, I was looking at the default configuration file. Currently, the 
> default configuration file is inconsistent with the module defaults. I 
> think it would be good to harmonize all these, so I posted a couple of 
> patches:
> 
> Harmonize default log files:
> http://marc.info/?l=netfilter-devel&m=148697928328626&w=2
> 
> Add missing default log files to logrotate configuration:
> http://marc.info/?l=netfilter-devel&m=148697928528629&w=2
> 
> I wish somebody would comment these.

Eric, let me know if you have some spare cycles for this. Otherwise I
will place them in the tree.

Thanks a lot!