* Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf
[not found] <a8e669c7-6f9a-405f-bac3-c7d0c33064eb@email.android.com>
@ 2017-03-06 17:06 ` Kaarle Ritvanen
2017-03-07 13:41 ` Pablo Neira Ayuso
0 siblings, 1 reply; 6+ messages in thread
From: Kaarle Ritvanen @ 2017-03-06 17:06 UTC (permalink / raw)
To: Eric Leblond; +Cc: Netfilter Devel
On Sun, 12 Feb 2017, Eric Leblond wrote:
> This is not correct. All the listed files are default value for various
> existing output modules so we should keep them.
Sorry, I was looking at the default configuration file. Currently, the
default configuration file is inconsistent with the module defaults. I
think it would be good to harmonize all these, so I posted a couple of
patches:
Harmonize default log files:
http://marc.info/?l=netfilter-devel&m=148697928328626&w=2
Add missing default log files to logrotate configuration:
http://marc.info/?l=netfilter-devel&m=148697928528629&w=2
I wish somebody would comment these.
BR,
Kaarle
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf
2017-03-06 17:06 ` [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf Kaarle Ritvanen
@ 2017-03-07 13:41 ` Pablo Neira Ayuso
0 siblings, 0 replies; 6+ messages in thread
From: Pablo Neira Ayuso @ 2017-03-07 13:41 UTC (permalink / raw)
To: Eric Leblond, Netfilter Devel; +Cc: Kaarle Ritvanen
On Mon, Mar 06, 2017 at 07:06:51PM +0200, Kaarle Ritvanen wrote:
> On Sun, 12 Feb 2017, Eric Leblond wrote:
>
> > This is not correct. All the listed files are default value for various
> > existing output modules so we should keep them.
>
> Sorry, I was looking at the default configuration file. Currently, the
> default configuration file is inconsistent with the module defaults. I
> think it would be good to harmonize all these, so I posted a couple of
> patches:
>
> Harmonize default log files:
> http://marc.info/?l=netfilter-devel&m=148697928328626&w=2
>
> Add missing default log files to logrotate configuration:
> http://marc.info/?l=netfilter-devel&m=148697928528629&w=2
>
> I wish somebody would comment these.
Eric, let me know if you have some spare cycles for this. Otherwise I
will place them in the tree.
Thanks a lot!
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf
@ 2017-02-03 11:24 Kaarle Ritvanen
2017-02-12 14:09 ` Pablo Neira Ayuso
2017-02-12 15:49 ` Eric Leblond
0 siblings, 2 replies; 6+ messages in thread
From: Kaarle Ritvanen @ 2017-02-03 11:24 UTC (permalink / raw)
To: netfilter-devel; +Cc: Kaarle Ritvanen
Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
---
ulogd.logrotate | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ulogd.logrotate b/ulogd.logrotate
index b3fb6d1..a865353 100644
--- a/ulogd.logrotate
+++ b/ulogd.logrotate
@@ -1,4 +1,4 @@
-/var/log/ulogd.log /var/log/ulogd.syslogemu /var/log/ulogd.pktlog /var/log/ulogd.pcap {
+/var/log/ulogd*.log {
missingok
sharedscripts
postrotate
--
2.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf
2017-02-03 11:24 Kaarle Ritvanen
@ 2017-02-12 14:09 ` Pablo Neira Ayuso
2017-02-12 14:46 ` Arturo Borrero Gonzalez
2017-02-12 15:49 ` Eric Leblond
1 sibling, 1 reply; 6+ messages in thread
From: Pablo Neira Ayuso @ 2017-02-12 14:09 UTC (permalink / raw)
To: Kaarle Ritvanen; +Cc: netfilter-devel, Eric Leblond
I'll let Eric decide to this small update.
On Fri, Feb 03, 2017 at 01:24:27PM +0200, Kaarle Ritvanen wrote:
> Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
> ---
> ulogd.logrotate | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ulogd.logrotate b/ulogd.logrotate
> index b3fb6d1..a865353 100644
> --- a/ulogd.logrotate
> +++ b/ulogd.logrotate
> @@ -1,4 +1,4 @@
> -/var/log/ulogd.log /var/log/ulogd.syslogemu /var/log/ulogd.pktlog /var/log/ulogd.pcap {
> +/var/log/ulogd*.log {
> missingok
> sharedscripts
> postrotate
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf
2017-02-03 11:24 Kaarle Ritvanen
2017-02-12 14:09 ` Pablo Neira Ayuso
@ 2017-02-12 15:49 ` Eric Leblond
1 sibling, 0 replies; 6+ messages in thread
From: Eric Leblond @ 2017-02-12 15:49 UTC (permalink / raw)
To: Kaarle Ritvanen, netfilter-devel
Hello,
On Fri, 2017-02-03 at 13:24 +0200, Kaarle Ritvanen wrote:
> Signed-off-by: Kaarle Ritvanen <kaarle.ritvanen@datakunkku.fi>
> ---
> ulogd.logrotate | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ulogd.logrotate b/ulogd.logrotate
> index b3fb6d1..a865353 100644
> --- a/ulogd.logrotate
> +++ b/ulogd.logrotate
> @@ -1,4 +1,4 @@
> -/var/log/ulogd.log /var/log/ulogd.syslogemu /var/log/ulogd.pktlog
This is not correct. All the listed files are default value for various
existing output modules so we should keep them.
> /var/log/ulogd.pcap {
> +/var/log/ulogd*.log {
> missingok
> sharedscripts
> postrotate
PS to Kaarle: resending because initial mail did not reach the ML.
BR,
--
Eric Leblond <eric@regit.org>
Blog: https://home.regit.org/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-07 13:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <a8e669c7-6f9a-405f-bac3-c7d0c33064eb@email.android.com>
2017-03-06 17:06 ` [PATCH ulogd2] adjust ulogd.logrotate to match ulogd.conf Kaarle Ritvanen
2017-03-07 13:41 ` Pablo Neira Ayuso
2017-02-03 11:24 Kaarle Ritvanen
2017-02-12 14:09 ` Pablo Neira Ayuso
2017-02-12 14:46 ` Arturo Borrero Gonzalez
2017-02-12 15:49 ` Eric Leblond
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).