From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [iptables PATCH] extensions: libxt_conntrack: Fix 'state' translation to nft Date: Tue, 7 Mar 2017 17:20:55 +0100 Message-ID: <20170307162055.GA4753@salvia> References: <20170307153507.14640-1-phil@nwl.cc> <20170307161729.GA2233@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Phil Sutter Return-path: Received: from mail.us.es ([193.147.175.20]:38670 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755476AbdCGQV3 (ORCPT ); Tue, 7 Mar 2017 11:21:29 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 8DADA65B17 for ; Tue, 7 Mar 2017 17:20:57 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 80E25DA7FA for ; Tue, 7 Mar 2017 17:20:57 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 4F995DA853 for ; Tue, 7 Mar 2017 17:20:55 +0100 (CET) Content-Disposition: inline In-Reply-To: <20170307161729.GA2233@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Tue, Mar 07, 2017 at 05:17:29PM +0100, Pablo Neira Ayuso wrote: > On Tue, Mar 07, 2017 at 04:35:07PM +0100, Phil Sutter wrote: > > While translating a conntrack state match in old syntax, matches are > > looked up by name, only. This returned the revision 0 entry since > > matches are registered in reverse order of appearance in the array > > passed to xtables_register_matches(). The problem is that revision 0 > > doesn't define an xlate callback. > > > > Fix this by reordering the matches in conntrack_mt_reg so that the > > highest revision one is found first. > > Applied, thanks Phil. Wait. Do you mean this case? # iptables-translate -I INPUT -m state --state NEW nft insert rule ip filter INPUT ct state new counter Hm, this works here.