From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH v2 nf] netfilter: don't track fragmented packets
Date: Wed, 8 Mar 2017 18:30:46 +0100 [thread overview]
Message-ID: <20170308173046.GA8605@salvia> (raw)
In-Reply-To: <20170303204400.21565-1-fw@strlen.de>
On Fri, Mar 03, 2017 at 09:44:00PM +0100, Florian Westphal wrote:
> Andrey reports syzkaller splat caused by
>
> NF_CT_ASSERT(!ip_is_fragment(ip_hdr(skb)));
>
> in ipv4 nat. But this assertion (and the comment) are wrong, this function
> does see fragments when IP_NODEFRAG setsockopt is used.
>
> As conntrack doesn't track packets without complete l4 header, only the
> first fragment is tracked.
>
> Because applying nat to first packet but not the rest makes no sense this
> also turns off tracking of all fragments.
Applied, thanks Florian.
prev parent reply other threads:[~2017-03-08 17:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 20:44 [PATCH v2 nf] netfilter: don't track fragmented packets Florian Westphal
2017-03-08 17:30 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170308173046.GA8605@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).