From: Florian Westphal <fw@strlen.de>
To: Dan Streetman <dan.streetman@canonical.com>
Cc: David Miller <davem@davemloft.net>,
fw@strlen.de, eric.dumazet@gmail.com, lkml@rkeene.org,
netdev@vger.kernel.org, netfilter-devel@vger.kernel.org
Subject: Re: ip_rcv_finish() NULL pointer kernel panic
Date: Mon, 13 Mar 2017 18:39:42 +0100 [thread overview]
Message-ID: <20170313173942.GB26782@breakpoint.cc> (raw)
In-Reply-To: <CAOZ2QJPUNm2ymTdcyW6HO9B2yhHv1MfeycywOajDSty0A6ZHFQ@mail.gmail.com>
Dan Streetman <dan.streetman@canonical.com> wrote:
> > But I have to say that this netfilter bridging fake dst has caused
> > several dozen bugs over the years, it is fundamentally a serious
> > problem in and of itself. It provides DST facilities by hand, in a
> > static object, without using any of the usual methods for creating and
> > facilitating dst objects.
> >
> > Therefore every time someone makes an adjustment to common dst code,
> > this turd (and yes, it _is_ a turd) breaks. Every single time.
> >
> > So in the long term, instead of polishing this turd, let's get rid of
> > it.
>
> I'm getting reports of this bug as well; is anyone working on removing
> the bridge fake dst?
I don't see how we can ever remove it (unless we remove the
call-iptables feature of course).
prev parent reply other threads:[~2017-03-13 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LNX.2.02.1701260627510.24491@maul.oc9.org>
[not found] ` <alpine.LNX.2.02.1701260927040.24491@maul.oc9.org>
2017-01-26 15:57 ` ip_rcv_finish() NULL pointer kernel panic Eric Dumazet
2017-01-26 16:02 ` Roy Keene
2017-01-26 16:24 ` Florian Westphal
2017-01-26 18:00 ` Eric Dumazet
2017-01-26 18:14 ` Eric Dumazet
2017-01-26 18:04 ` David Miller
2017-03-13 17:30 ` Dan Streetman
2017-03-13 17:39 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313173942.GB26782@breakpoint.cc \
--to=fw@strlen.de \
--cc=dan.streetman@canonical.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=lkml@rkeene.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).