From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org,
Liping Zhang <zlpnobody@gmail.com>,
Karel Rericha <karel@unitednetworks.cz>
Subject: Re: [PATCH nf-next] netfilter: nft_set_rbtree: use per-set rwlock to improve the scalability
Date: Mon, 13 Mar 2017 19:32:33 +0100 [thread overview]
Message-ID: <20170313183233.GB565@salvia> (raw)
In-Reply-To: <1489318727-38911-1-git-send-email-zlpnobody@163.com>
On Sun, Mar 12, 2017 at 07:38:47PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> Karel Rericha reported that in his test case, ICMP packets going through
> boxes had normally about 5ms latency. But when running nft, actually
> listing the sets with interval flags, latency would go up to 30-100ms.
> This was observed when router throughput is from 600Mbps to 2Gbps.
>
> This is because we use a single global spinlock to protect the whole
> rbtree sets, so "dumping sets" will race with the "key lookup" inevitably.
> But actually they are all _readers_, so it's ok to convert the spinlock
> to rwlock to avoid competition between them. Also use per-set rwlock since
> each set is independent.
Also applied, thanks for testing Karel.
prev parent reply other threads:[~2017-03-13 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-12 11:38 [PATCH nf-next] netfilter: nft_set_rbtree: use per-set rwlock to improve the scalability Liping Zhang
2017-03-13 18:32 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313183233.GB565@salvia \
--to=pablo@netfilter.org \
--cc=karel@unitednetworks.cz \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).