From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: netfilter-devel@vger.kernel.org, jscherpelz@google.com
Subject: Re: [PATCH] iptables: set the path of the lock file via a configure option.
Date: Tue, 14 Mar 2017 11:22:06 +0100 [thread overview]
Message-ID: <20170314102206.GA1933@salvia> (raw)
In-Reply-To: <20170314085550.10153-1-lorenzo@google.com>
On Tue, Mar 14, 2017 at 05:55:50PM +0900, Lorenzo Colitti wrote:
> Currently the iptables lock is hardcoded as "/run/xtables.lock".
> Allow users to change this path using the --with-xt-lock-name
> option to ./configure option. This is useful on systems like
> Android which do not have /run.
>
> Tested on Ubuntu, as follows:
>
> 1. By default, the lock is placed in /run/xtables.lock:
>
> $ make distclean-recursive && ./autogen.sh &&
> ./configure --disable-nftables --prefix /tmp/iptables &&
> make -j64 &&
> make install &&
> sudo strace -e open,flock /tmp/iptables/sbin/iptables -L foo
> ...
> open("/run/xtables.lock", O_RDONLY|O_CREAT, 0600) = 3
> flock(3, LOCK_EX|LOCK_NB) = 0
> iptables: No chain/target/match by that name.
>
> 2. Specifying the lock results in the expected location being
> used:
>
> $ make distclean-recursive && ./autogen.sh && \
> ./configure --disable-nftables --prefix /tmp/iptables \
> --with-xt-lock-name=/tmp/iptables/run/xtables.lock &&
> make -j64 &&
> make install &&
> sudo strace -e open,flock /tmp/iptables/sbin/iptables -L foo
> ...
> open("/tmp/iptables/run/xtables.lock", O_RDONLY|O_CREAT, 0600) = 3
> flock(3, LOCK_EX|LOCK_NB) = 0
> iptables: No chain/target/match by that name.
Applied, thanks Lorenzo!
prev parent reply other threads:[~2017-03-14 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 8:55 [PATCH] iptables: set the path of the lock file via a configure option Lorenzo Colitti
2017-03-14 10:22 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314102206.GA1933@salvia \
--to=pablo@netfilter.org \
--cc=jscherpelz@google.com \
--cc=lorenzo@google.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).