From: Pablo Neira Ayuso <pablo@netfilter.org>
To: fgao@ikuai8.com
Cc: netfilter-devel@vger.kernel.org, gfree.wind@gmail.com
Subject: Re: [PATCH nf 1/1] netfilter: helper: Fix possible panic caused by invoking expectfn unloaded
Date: Wed, 15 Mar 2017 14:07:26 +0100 [thread overview]
Message-ID: <20170315130726.GA6318@salvia> (raw)
In-Reply-To: <1489472766-89568-1-git-send-email-fgao@ikuai8.com>
On Tue, Mar 14, 2017 at 02:26:06PM +0800, fgao@ikuai8.com wrote:
> From: Gao Feng <fgao@ikuai8.com>
>
> The helper module permits the helper modules register expectfn, and
> it could be hold by external caller. But when the module is unloaded,
> there may be some pending expect nodes which still hold the function
> reference. It may cause unexpected behavior, even panic.
>
> Now it would delete the expect nodes which uses the expectfn when
> unregister expectfn. And it must use the rcu_read_lock to protect
> the expectfn until insert it or doesn't access it ever.
Expectations should be removed by when the helper module is gone, so
what is the problem here?
next prev parent reply other threads:[~2017-03-15 13:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-14 6:26 [PATCH nf 1/1] netfilter: helper: Fix possible panic caused by invoking expectfn unloaded fgao
2017-03-15 13:07 ` Pablo Neira Ayuso [this message]
2017-03-15 22:57 ` Gao Feng
2017-03-17 13:08 ` Pablo Neira Ayuso
2017-03-17 14:09 ` Gao Feng
2017-03-18 4:02 ` Gao Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315130726.GA6318@salvia \
--to=pablo@netfilter.org \
--cc=fgao@ikuai8.com \
--cc=gfree.wind@gmail.com \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).