From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Subject: Re: [nft PATCH] proto: Add some exotic ICMPv6 types Date: Wed, 15 Mar 2017 20:50:51 +0100 Message-ID: <20170315195051.GE17939@orbyte.nwl.cc> References: <20170315155501.8603-1-phil@nwl.cc> <20170315161514.GB28159@salvia> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netfilter-devel@vger.kernel.org To: Pablo Neira Ayuso Return-path: Received: from orbyte.nwl.cc ([151.80.46.58]:39681 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751416AbdCOTux (ORCPT ); Wed, 15 Mar 2017 15:50:53 -0400 Content-Disposition: inline In-Reply-To: <20170315161514.GB28159@salvia> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Wed, Mar 15, 2017 at 05:15:14PM +0100, Pablo Neira Ayuso wrote: > On Wed, Mar 15, 2017 at 04:55:01PM +0100, Phil Sutter wrote: > > This adds support for matching on inverse ND messages as defined by > > RFC3122 (not implemented in Linux) and MLDv2 as defined by RFC3810. > > > > Note that ICMPV6_MLD2_REPORT macro is defined in linux/icmpv6.h but > > including that header leads to conflicts with symbols defined in > > netinet/icmp6.h. > > > > In addition to the above, "mld-listener-done" is introduced as an alias > > for "mld-listener-reduction". > > > > Signed-off-by: Phil Sutter > > --- > > This should resolve netfilter BZ#926. > > --- > > src/proto.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/src/proto.c b/src/proto.c > > index fb965304e59d9..6a8eed936d858 100644 > > --- a/src/proto.c > > +++ b/src/proto.c > > @@ -632,6 +632,10 @@ const struct proto_desc proto_ip = { > > > > #include > > > > +#define IND_NEIGHBOR_SOLICIT 141 > > +#define IND_NEIGHBOR_ADVERT 142 > > +#define ICMPV6_MLD2_REPORT 143 > > + > > static const struct symbol_table icmp6_type_tbl = { > > .base = BASE_DECIMAL, > > .symbols = { > > @@ -644,12 +648,16 @@ static const struct symbol_table icmp6_type_tbl = { > > SYMBOL("mld-listener-query", MLD_LISTENER_QUERY), > > SYMBOL("mld-listener-report", MLD_LISTENER_REPORT), > > SYMBOL("mld-listener-reduction", MLD_LISTENER_REDUCTION), > > + SYMBOL("mld-listener-done", MLD_LISTENER_REDUCTION), > > This one is duplicated, right? Yes, it is the alias which was suggested in the ticket. Is this OK, or should we rather respond with WONTFIX? I realize this patch lacks an update to man page and a few test cases. Should I reroll or send a follow-up? Thanks, Phil