From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft] src: allow update of net base w. meta l4proto icmpv6
Date: Wed, 22 Mar 2017 17:07:26 +0100 [thread overview]
Message-ID: <20170322160726.GA23136@salvia> (raw)
In-Reply-To: <20170322154400.GB8584@breakpoint.cc>
On Wed, Mar 22, 2017 at 04:44:00PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > Hm, I wonder why you need this new line in proto_inet_service:
> >
> > + PROTO_LINK(IPPROTO_ICMPV6, &proto_icmp6),
>
> meta_expr_pctx_update calls proto_find_upper(), without this
> that returns NULL and proto base is set to 'unknown'.
Oh right.
Will this still happen if you tell nft to generate the dependency
using meta l4proto instead of ip6 nexthdr?
next prev parent reply other threads:[~2017-03-22 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 18:54 [PATCH nft] src: allow update of net base w. meta l4proto icmpv6 Florian Westphal
2017-03-22 13:09 ` Pablo Neira Ayuso
2017-03-22 13:44 ` Florian Westphal
2017-03-22 15:29 ` Pablo Neira Ayuso
2017-03-22 15:32 ` Pablo Neira Ayuso
2017-03-22 15:44 ` Florian Westphal
2017-03-22 16:07 ` Pablo Neira Ayuso [this message]
2017-03-22 19:22 ` Florian Westphal
2017-03-24 11:50 ` Pablo Neira Ayuso
2017-03-24 12:21 ` Florian Westphal
2017-03-29 10:13 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322160726.GA23136@salvia \
--to=pablo@netfilter.org \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).