From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Liping Zhang <zlpnobody@163.com>
Cc: netfilter-devel@vger.kernel.org, Liping Zhang <zlpnobody@gmail.com>
Subject: Re: [PATCH libnetfilter_cthelper] src: fix incorrect building and parsing of the NFCTH_POLICY_SETX attribute
Date: Fri, 24 Mar 2017 13:25:30 +0100 [thread overview]
Message-ID: <20170324122530.GA3315@salvia> (raw)
In-Reply-To: <1490020522-26359-1-git-send-email-zlpnobody@163.com>
On Mon, Mar 20, 2017 at 10:35:22PM +0800, Liping Zhang wrote:
> From: Liping Zhang <zlpnobody@gmail.com>
>
> In nfct_helper_nlmsg_build_policy(), we always set the attribute type to
> NFCTH_POLICY_SET, so we cannot add more than one nfct_helper_policy to
> the kernel.
>
> Also: in nfct_helper_nlmsg_parse_policy(), we will increase the
> helper->policy_num for each nfct_helper_policy, but we mistakenly set it
> to the total number of nfct_helper_policy. So when the total number is
> more than 3, later out of bound access will happen.
Applied, thanks Liping.
prev parent reply other threads:[~2017-03-24 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 14:35 [PATCH libnetfilter_cthelper] src: fix incorrect building and parsing of the NFCTH_POLICY_SETX attribute Liping Zhang
2017-03-24 12:25 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324122530.GA3315@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=zlpnobody@163.com \
--cc=zlpnobody@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).