netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: gfree.wind@foxmail.com
Cc: kbuild-all@01.org, pablo@netfilter.org,
	netfilter-devel@vger.kernel.org, gfree.wind@foxmail.com,
	Gao Feng <fgao@ikuai8.com>
Subject: Re: [PATCH nf v4 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register
Date: Mon, 27 Mar 2017 22:01:08 +0800	[thread overview]
Message-ID: <201703272146.nP5tRJya%fengguang.wu@intel.com> (raw)
In-Reply-To: <1490408646-26051-1-git-send-email-gfree.wind@foxmail.com>

[-- Attachment #1: Type: text/plain, Size: 2942 bytes --]

Hi Gao,

[auto build test WARNING on nf/master]

url:    https://github.com/0day-ci/linux/commits/gfree-wind-foxmail-com/netfilter-snmp-Fix-one-possible-panic-when-snmp_trap_helper-fail-to-register/20170327-081220
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
config: x86_64-randconfig-s2-03272042 (attached as .config)
compiler: gcc-4.4 (Debian 4.4.7-8) 4.4.7
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   net/ipv4//netfilter/nf_nat_snmp_basic.c: In function 'nf_nat_snmp_basic_init':
>> net/ipv4//netfilter/nf_nat_snmp_basic.c:1281: warning: unused variable 'ret'

vim +/ret +1281 net/ipv4//netfilter/nf_nat_snmp_basic.c

807467c22 Patrick McHardy   2006-12-02  1265  	.help			= help,
6002f266b Patrick McHardy   2008-03-25  1266  	.expect_policy		= &snmp_exp_policy,
807467c22 Patrick McHardy   2006-12-02  1267  	.name			= "snmp_trap",
807467c22 Patrick McHardy   2006-12-02  1268  	.tuple.src.l3num	= AF_INET,
09640e636 Harvey Harrison   2009-02-01  1269  	.tuple.src.u.udp.port	= cpu_to_be16(SNMP_TRAP_PORT),
807467c22 Patrick McHardy   2006-12-02  1270  	.tuple.dst.protonum	= IPPROTO_UDP,
807467c22 Patrick McHardy   2006-12-02  1271  };
807467c22 Patrick McHardy   2006-12-02  1272  
807467c22 Patrick McHardy   2006-12-02  1273  /*****************************************************************************
807467c22 Patrick McHardy   2006-12-02  1274   *
807467c22 Patrick McHardy   2006-12-02  1275   * Module stuff.
807467c22 Patrick McHardy   2006-12-02  1276   *
807467c22 Patrick McHardy   2006-12-02  1277   *****************************************************************************/
807467c22 Patrick McHardy   2006-12-02  1278  
807467c22 Patrick McHardy   2006-12-02  1279  static int __init nf_nat_snmp_basic_init(void)
807467c22 Patrick McHardy   2006-12-02  1280  {
807467c22 Patrick McHardy   2006-12-02 @1281  	int ret = 0;
807467c22 Patrick McHardy   2006-12-02  1282  
93557f53e Jiri Olsa         2011-01-18  1283  	BUG_ON(nf_nat_snmp_hook != NULL);
a9b3cd7f3 Stephen Hemminger 2011-08-01  1284  	RCU_INIT_POINTER(nf_nat_snmp_hook, help);
93557f53e Jiri Olsa         2011-01-18  1285  
9b25a2987 Gao Feng          2017-03-25  1286  	return nf_conntrack_helper_register(&snmp_trap_helper);
807467c22 Patrick McHardy   2006-12-02  1287  }
807467c22 Patrick McHardy   2006-12-02  1288  
807467c22 Patrick McHardy   2006-12-02  1289  static void __exit nf_nat_snmp_basic_fini(void)

:::::: The code at line 1281 was first introduced by commit
:::::: 807467c22a12381985878be23c778657fc0364d0 [NETFILTER]: nf_nat: add SNMP NAT helper port

:::::: TO: Patrick McHardy <kaber@trash.net>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 31288 bytes --]

  parent reply	other threads:[~2017-03-27 14:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25  2:24 [PATCH nf v4 1/1] netfilter: snmp: Fix one possible panic when snmp_trap_helper fail to register gfree.wind
2017-03-25  8:16 ` Liping Zhang
2017-03-25 10:00   ` Gao Feng
2017-03-27 14:01 ` kbuild test robot [this message]
2017-03-27 14:08   ` Gao Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201703272146.nP5tRJya%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=fgao@ikuai8.com \
    --cc=gfree.wind@foxmail.com \
    --cc=kbuild-all@01.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).