From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] net: Remove unnecessary cast on void pointer Date: Sat, 1 Apr 2017 16:48:21 -0700 Message-ID: <20170401164821.036f1b41@plumbers-lap.home.lan> References: <20170328190516.GA19531@singhal-Inspiron-5558> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: pablo@netfilter.org, kadlec@blackhole.kfki.hu, davem@davemloft.net, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, gregkh@linuxfoundation.org, Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , bridge@lists.linux-foundation.org To: simran singhal Return-path: In-Reply-To: <20170328190516.GA19531@singhal-Inspiron-5558> Sender: netdev-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org On Wed, 29 Mar 2017 00:35:16 +0530 simran singhal wrote: > The following Coccinelle script was used to detect this: > @r@ > expression x; > void* e; > type T; > identifier f; > @@ > ( > *((T *)e) > | > ((T *)x)[...] > | > ((T*)x)->f > | > > - (T*) > e > ) > > Unnecessary parantheses are also remove. > > Signed-off-by: simran singhal Looks good Reviewed-by: Stephen Hemminger