From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: wensong@linux-vs.org, Simon Horman <horms@verge.net.au>,
outreachy-kernel@googlegroups.com, Julian Anastasov <ja@ssi.bg>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
davem@davemloft.net, netdev@vger.kernel.org,
lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator
Date: Tue, 4 Apr 2017 19:56:00 +0200 [thread overview]
Message-ID: <20170404175600.GB1154@salvia> (raw)
In-Reply-To: <20170404174111.GB7257@verge.net.au>
On Tue, Apr 04, 2017 at 01:41:11PM -0400, Simon Horman wrote:
> On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote:
> > Replace explicit NULL comparison with ! operator to simplify code.
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> > net/netfilter/ipvs/ip_vs_ctl.c | 8 ++---
> > net/netfilter/ipvs/ip_vs_proto.c | 8 ++---
>
> I count 18 instances of "!= NULL in net/netfilter/ipvs/ip_vs_proto but this
> patch only seems to update 8 of them. I would prefer to fix all or none of
> them.
Agreed.
Please address all instances and resubmit.
next prev parent reply other threads:[~2017-04-04 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 10:15 [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator Arushi Singhal
2017-04-04 17:41 ` Simon Horman
2017-04-04 17:56 ` Pablo Neira Ayuso [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-29 6:44 [PATCH] net: netfilter: replace " Arushi Singhal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404175600.GB1154@salvia \
--to=pablo@netfilter.org \
--cc=arushisinghal19971997@gmail.com \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=wensong@linux-vs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).