netfilter-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: netfilter-devel@vger.kernel.org,
	outreachy-kernel <outreachy-kernel@googlegroups.com>
Subject: Re: [PATCH 1/2] iptables: Remove explicit static variables initalization.
Date: Thu, 6 Apr 2017 18:22:14 +0200	[thread overview]
Message-ID: <20170406162214.GA5655@salvia> (raw)
In-Reply-To: <58dc0a89.549c620a.6eb0a.5c33@mx.google.com>

On Thu, Mar 30, 2017 at 12:57:02AM +0530, Varsha Rao wrote:
> Static variables are initialized to zero by default, so remove explicit
> initalization. This patch fixes the checkpatch issue.

Applied.

But I had to add this chunk:

diff --git a/iptables/xtables-restore.c b/iptables/xtables-restore.c
index a551c8c19f7f..6afa0d0ec5b1 100644
--- a/iptables/xtables-restore.c
+++ b/iptables/xtables-restore.c
@@ -24,7 +24,7 @@
 #define DEBUGP(x, args...)
 #endif
 
-static int counters = 0, verbose = 0, noflush = 0;
+static int counters, verbose, noflush;
 
 /* Keeping track of external matches and targets.  */
 static const struct option options[] = {

You have to be more careful. It's good if you just fix all spots in
one single go.

Thanks!

  reply	other threads:[~2017-04-06 16:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1490815157.git.rvarsha016@gmail.com>
2017-03-29 19:27 ` [PATCH 1/2] iptables: Remove explicit static variables initalization Varsha Rao
2017-04-06 16:22   ` Pablo Neira Ayuso [this message]
2017-03-29 19:27 ` [PATCH 2/2] iptables: Remove unnecessary braces Varsha Rao
2017-04-06 16:22   ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170406162214.GA5655@salvia \
    --to=pablo@netfilter.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=rvarsha016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).