From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH 1/2] net: netfilter: Remove typedef from "typedef struct field_t" Date: Thu, 6 Apr 2017 18:26:54 +0200 Message-ID: <20170406162654.GA5777@salvia> References: <20170325122756.8743-1-arushisinghal19971997@gmail.com> <20170325122756.8743-2-arushisinghal19971997@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kadlec@blackhole.kfki.hu, davem@davemloft.net, outreachy-kernel@googlegroups.com, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Arushi Singhal Return-path: Received: from mail.us.es ([193.147.175.20]:34694 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934359AbdDFQ1F (ORCPT ); Thu, 6 Apr 2017 12:27:05 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 3EE7811ADC1 for ; Thu, 6 Apr 2017 18:27:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 2EEA3BAC28 for ; Thu, 6 Apr 2017 18:27:00 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 1D600BAC46 for ; Thu, 6 Apr 2017 18:26:58 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20170325122756.8743-2-arushisinghal19971997@gmail.com> Sender: netfilter-devel-owner@vger.kernel.org List-ID: On Sat, Mar 25, 2017 at 05:57:55PM +0530, Arushi Singhal wrote: > This patch removes typedefs from struct and renames it from "typedef struct > field_t" to "struct field" as per kernel coding standards." > > Signed-off-by: Arushi Singhal > --- > net/netfilter/nf_conntrack_h323_asn1.c | 68 +++++++++++++++++----------------- > 1 file changed, 34 insertions(+), 34 deletions(-) > > diff --git a/net/netfilter/nf_conntrack_h323_asn1.c b/net/netfilter/nf_conntrack_h323_asn1.c > index 89b2e46925c4..fb8cf238a76f 100644 > --- a/net/netfilter/nf_conntrack_h323_asn1.c > +++ b/net/netfilter/nf_conntrack_h323_asn1.c > @@ -77,7 +77,7 @@ > > > /* ASN.1 Field Structure */ > -typedef struct field_t { > +struct field { Probably better if you rename this to 'struct h323_field' to make sure compilation doesn't break due to structure name pollution. And we also got a report from kbuild robot that would be good to investigate.